Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): cherry-pick assets and collectible order fixes #14453

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix(wallet): cherry-pick assets and collectible order fixes #14453

merged 3 commits into from
Apr 18, 2024

Commits on Apr 17, 2024

  1. fix(wallet) serializing type for collectibles settings to backend 

    It seems `%*` operator we use in the `rpc` generics doesn't use the
`serializedFieldName` marker and `type` was serialized as `itemType`
and value the enum name instead of `type` and integer value

Updates: #13971
    @stefandunca
    stefandunca committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a239307 View commit details
    Browse the repository at this point in the history

  2. feat(wallet) save/load collectibles user handled state in DB 

    Add a separation layer for save/load/clear to ManageTokensModel
so that we can save/load from external sources.
The separate layer is composed of JSON as protocol, a set of signals
and slots for interface. The implementation forwards data to current
QSettings for storybook and nim controllers for the app.

Updates #13313, #13312
    @stefandunca
    stefandunca committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a2b0165 View commit details
    Browse the repository at this point in the history

  3. fix(wallet): update wallet assets and collectibles order on user action 

    Add a specific state to the saveSettings action to update the model
by reloading the data.

The previous implementation was using the same save address which
doesn't update. Either in the past there was a side effect that made it
work or it was never working.

Closes #14365
    @stefandunca
    stefandunca committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4e24d20 View commit details
    Browse the repository at this point in the history