[Community Join] backport community join flow fixes to 2.28.1 #14268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (17)
|
21 tasks
saledjenic
approved these changes
Apr 3, 2024
- manually setup the TAB focus chain; in the future, this should be done properly on all new components using FocusScopes and similar Fixes #13891
…ng icon - Change text and remove existing icon. - Removed unnecessary property `loginType` on different files. - Renamed signals to be more accurate with existing requirements. Closes #14098
…ipSetupDialog Closes: #14144
- update shared addresses dialog to avoid small jumps when selecting/unselecting accounts due to requirements check text displayed - display the pending text and spinner next to the Permissions header Fixes #14103
…T MET (#14164) * fix(JoinCommunity): Add missing state ONLY private permissions and NOT MET - Modified `becomeMemberModel` in store to provide all member permissions. - Modified permissions model filter to only discard permissions that are private and NOT met. - Updated `storybook/PermissionsModel` with new only private permissions and added new model option in corresponding pages. Closes #14104 * fix(JoinCommunity): Text position when all channels hidden Updated text position when `allChannelsAreHiddenBecauseNotPermitted` in community join process
- Removed function in merge while it's still needed. - Modified logic when channels hidden to take into account also `viewOnly` permission cases.
…, authentication is not triggered Closes #14175
…correct showing the password one instead Closes #14173
seems like this check had gone missing
…lling request - Added dialog instead of calling directly to the cancel method. - Updated `Cancel` button format according to figma in `CommunityMembershipSetupDialog`. Closes #14097
- implement the eligibility check in C++, returning the highest possible role the user would be allowed to join under - enable/disable the "Share" button based on the above permissions check - remove all the locally placed components, access teh popup only via Global/Popups - calculate the `accessType` internally based on the permissions present - update the eligibility as the async check for permissions is finished - fix the permissions panel background color - partially revert the share/finish/cancel buttons behavior; it must be one button due to StatusStackModal limitations - fix some other minor UI issues or differences to current Figma designs - adjust SB, add the possibility to play around with different permission models Fixes #14100
… roles initialization
…ount's delegate tags Closes: #14102
…hen adding a permission fixes #13561
- speed up the construction of the permissions overview panels
- implement sorting of the wallet accounts by the number of tokens (aka tags) and then by alphabet - due to the delegate complexity here and usage of nested models, keep track of the tags count separately and outside of the model - this will be improved later on as part of the complete sort/order design described in #14192 Fixes #14101
jrainville
force-pushed
the
backport-join-community-flow-fixes-to-release-2.28.x
branch
from
a3dfc57
to
7919da7
Compare
we already build it anyway in the Popups.qml when opening the community intro dialog in all the flows
- don't use the expensive `ExpressionFoo` in SFPM, just use `AnyOf/AllOf` combinations where possible - in HoldingsSelectionModel, don't call the `getTokenByKey` twice to construct the `text`, once is enough - lastly, rewrite the JS helper `PermissionsHelpers.getTokenByKey` to C++; this method gets called recursively way too often from many places In the longterm, we should provide a specific C++ transformation model for SharedAddressesPermissionsPanel to follow the UI requirements more closely; that way we'd be able to fix the issues here for good Fixes #14276
…es to be joined The new property is added to allow indicating which roles from the right model should be used. It prevents from unnecessary renamings. Closes: #14298
Earier attempts to initialize proxy may fail bc left/right models may be not ready when they are set. It may lead to a situation where the model remains uninitialized and reporint 0 row count.
- removed multiple filtering separately for each category - no instantiation of all delegates up front (regular ListView approach used) - fixed category selection when filtering - selecting/deselecting only items fulfilling search criteria - significant simplification of the code Closes: #14275
…t is pending - disallow changing the Shared addresses while our request to join community is still pending Fixes #14292
alexjba
approved these changes
Apr 11, 2024
micieslak
approved these changes
Apr 11, 2024
|
@jrainville @iurimatias ready to merge! |
jrainville
deleted the
backport-join-community-flow-fixes-to-release-2.28.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
(see the individual commits for explanation)
Fixes #14266
Affected areas
Join community flows
Screenshot of functionality (including design for comparison)