Chore/cherry pick profile showcase impl in 2.28.1 #14267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjba
requested review from
MishkaRogachev,
caybro,
micieslak,
alexandraB99 and
noeliaSD
Jenkins BuildsClick to see older builds (18)
|
|
TODO: Fix status-go version to include only the necessary commits |
|
Corresponding status-go PR: status-im/status-go#5011 |
alexjba
commented
Apr 3, 2024
| self.contactsService.fetchProfileShowcaseAccountsByAddress(address) | ||
|
|
||
| proc getEnabledChainIds*(self: Controller): seq[int] = | ||
| return self.networkService.getNetworks().filter(n => n.enabled).map(n => n.chainId) |
There was a problem hiding this comment.
@MishkaRogachev had a conflict here because on master we're using a new API for the networks. Solved using getNetworks instead of getCurrentNetworks
There was a problem hiding this comment.
yea, getNetworks should be fine
caybro
approved these changes
Apr 8, 2024
alexjba
force-pushed
the
chore/cherry-pick-profile-showcase-impl
branch
from
7ab85b3
to
831f8d8
Compare
|
Updated status-go version to include the profile showcase updates |
MishkaRogachev
approved these changes
Apr 12, 2024
* Feat: New showcase models for a contact * feat(ProfileShowcase): Integrate the new profile showcase backend * fix(Storybook): Fix ProfileShowcaseModelsPage * fix: fetch only requested profile showcase data Support PR for status-im/status-go#4982 * feat: Load and validate profile showcase for a contact in two steps * fix: fetching criteria for profile showcase collectibles * fix: review fixes --------- Co-authored-by: Alex Jbanca <alexjb@status.im>
…t commit to the old networks API
alexjba
force-pushed
the
chore/cherry-pick-profile-showcase-impl
branch
from
831f8d8
to
5e7a1a9
Compare
|
@iurimatias @jrainville This is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes #14264
Cherry-picking profile showcase commits needed for 2.28.1