Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): displaying L1 gas cost in UI #14149

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(wallet): displaying L1 gas cost in UI #14149

merged 1 commit into from
Mar 28, 2024

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Mar 25, 2024

Corresponding status-go PR:

Fixes #13892

@Khushboo-dev-cpp could you please help on this or take over from this point on?

I introduced L2 fee property on the status-go side and added it to the Fees component on the UI, but now I see a discrepancy between the values displayed in Fees section and fees displayed in the Send modal popup.

We also need a proper design for it.

4

@status-im-auto
Copy link
Member

status-im-auto commented Mar 25, 2024

Jenkins Builds

Click to see older builds (18)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eefcde4 #1 2024-03-25 16:31:50 ~5 min tests/nim 📄log
✔️ eefcde4 #1 2024-03-25 16:34:46 ~8 min macos/aarch64 🍎dmg
✔️ eefcde4 #1 2024-03-25 16:37:40 ~11 min tests/ui 📄log
✔️ eefcde4 #1 2024-03-25 16:40:12 ~13 min macos/x86_64 🍎dmg
✔️ eefcde4 #1 2024-03-25 16:42:10 ~16 min linux/x86_64 📦tgz
✔️ eefcde4 #1 2024-03-25 16:50:57 ~24 min windows/x86_64 💿exe
✔️ b3c73c0 #2 2024-03-26 12:05:13 ~5 min macos/aarch64 🍎dmg
✔️ b3c73c0 #2 2024-03-26 12:06:30 ~6 min tests/nim 📄log
✔️ b3c73c0 #2 2024-03-26 12:08:33 ~8 min macos/x86_64 🍎dmg
✔️ b3c73c0 #2 2024-03-26 12:11:59 ~11 min tests/ui 📄log
✔️ b3c73c0 #2 2024-03-26 12:18:45 ~18 min linux/x86_64 📦tgz
✔️ b3c73c0 #2 2024-03-26 12:24:21 ~24 min windows/x86_64 💿exe
✔️ 97ff669 #3 2024-03-26 13:58:32 ~5 min macos/aarch64 🍎dmg
✔️ 97ff669 #3 2024-03-26 13:59:51 ~6 min tests/nim 📄log
✔️ 97ff669 #3 2024-03-26 14:02:52 ~9 min macos/x86_64 🍎dmg
✔️ 97ff669 #3 2024-03-26 14:04:28 ~11 min tests/ui 📄log
✔️ 97ff669 #3 2024-03-26 14:07:57 ~14 min linux/x86_64 📦tgz
✔️ 97ff669 #3 2024-03-26 14:17:33 ~24 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4d77feb #4 2024-03-27 07:33:02 ~6 min tests/nim 📄log
✔️ 4d77feb #4 2024-03-27 07:34:42 ~7 min macos/aarch64 🍎dmg
✔️ 4d77feb #4 2024-03-27 07:37:58 ~11 min tests/ui 📄log
✔️ 4d77feb #4 2024-03-27 07:38:18 ~11 min macos/x86_64 🍎dmg
✔️ 4d77feb #4 2024-03-27 07:40:47 ~14 min linux/x86_64 📦tgz
✔️ 4d77feb #4 2024-03-27 07:51:15 ~24 min windows/x86_64 💿exe
✔️ cde5a46 #5 2024-03-27 15:48:50 ~5 min macos/aarch64 🍎dmg
✔️ cde5a46 #5 2024-03-27 15:49:55 ~6 min tests/nim 📄log
✔️ cde5a46 #5 2024-03-27 15:53:42 ~10 min macos/x86_64 🍎dmg
✔️ cde5a46 #5 2024-03-27 15:54:29 ~11 min tests/ui 📄log
✔️ cde5a46 #5 2024-03-27 15:57:08 ~14 min linux/x86_64 📦tgz
✔️ cde5a46 #5 2024-03-27 16:06:40 ~23 min windows/x86_64 💿exe

@Khushboo-dev-cpp
Copy link
Contributor

I introduced L2 fee property on the status-go side and added it to the Fees component on the UI, but now I see a discrepancy between the values displayed in Fees section and fees displayed in the Send modal popup.

We also need a proper design for it.

Hey @saledjenic ! Sure I can can we create a follow up task for this? so that all questions from design also can be followed up there?

@saledjenic
Copy link
Contributor Author

@Khushboo-dev-cpp that would be great, let's sync with @alaibe first.

@alaibe
Copy link
Collaborator

alaibe commented Mar 26, 2024

I'd suggest merge only status-go then @Khushboo-dev-cpp take over that PR?

@saledjenic
Copy link
Contributor Author

I'd suggest merge only status-go then @Khushboo-dev-cpp take over that PR?

That's fine, since it won't break anything will do that once statusgo PR gets approved.

@saledjenic saledjenic force-pushed the L1-gas-price branch 2 times, most recently from 97ff669 to 4d77feb Compare March 27, 2024 07:26
@saledjenic
Copy link
Contributor Author

@Khushboo-dev-cpp an update for you, the status-go part is merged and updated here, this PR is ready for you to take it over. :)

@Khushboo-dev-cpp
Copy link
Contributor

@benjthayer need your help on how to display L1 fees for transaction on Optimism in the fees section

@Khushboo-dev-cpp
Copy link
Contributor

image

Ive fixed the issues of the values not matching.Now waiting for Ben to clarify how it should be shown on the UI :)

@Khushboo-dev-cpp Khushboo-dev-cpp self-assigned this Mar 27, 2024
@Khushboo-dev-cpp
Copy link
Contributor

Created follow up task for design on how to show the L1 fees #14208

Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@saledjenic saledjenic merged commit d9945b3 into master Mar 28, 2024
8 checks passed
@saledjenic saledjenic deleted the L1-gas-price branch March 28, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Gas Estimation says it will cost 0.01$ to mint a token, but in the end, it cost 30$+
4 participants