Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/add object name activity center #14029

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Valentina1133
Copy link
Contributor

What does the PR do

Added object names for some activity center elements

Affected areas

ui/StatusQ/src/StatusQ/Controls/StatusActivityCenterButton.qml
ui/app/mainui/activitycenter/panels/ActivityCenterPopupTopBarPanel.qml

@status-im-auto
Copy link
Member

status-im-auto commented Mar 19, 2024

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 29cccd2 #1 2024-03-19 11:36:08 ~6 min macos/aarch64 🍎dmg
✔️ 29cccd2 #1 2024-03-19 11:36:25 ~6 min tests/nim 📄log
29cccd2 #1 2024-03-19 11:41:03 ~11 min tests/ui 📄log
✔️ 29cccd2 #1 2024-03-19 11:42:37 ~12 min macos/x86_64 🍎dmg
✔️ 29cccd2 #1 2024-03-19 11:47:23 ~17 min linux/x86_64 📦tgz
✔️ 29cccd2 #1 2024-03-19 11:55:07 ~25 min windows/x86_64 💿exe
✔️ 29cccd2 #2 2024-03-19 12:49:05 ~11 min tests/ui 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
f0e6b75 #2 2024-03-20 07:45:24 ~2 min macos/aarch64 📄log
f0e6b75 #2 2024-03-20 07:47:43 ~5 min macos/x86_64 📄log
✔️ f0e6b75 #2 2024-03-20 07:48:09 ~5 min tests/nim 📄log
f0e6b75 #2 2024-03-20 07:50:58 ~8 min linux/x86_64 📄log
✔️ f0e6b75 #3 2024-03-20 07:53:17 ~10 min tests/ui 📄log
f0e6b75 #2 2024-03-20 07:58:32 ~16 min windows/x86_64 📄log
✔️ 70e4b7d #3 2024-03-20 08:04:48 ~5 min macos/aarch64 🍎dmg
✔️ 70e4b7d #3 2024-03-20 08:06:05 ~7 min tests/nim 📄log
✔️ 70e4b7d #3 2024-03-20 08:06:10 ~7 min macos/x86_64 🍎dmg
✔️ 70e4b7d #4 2024-03-20 08:10:24 ~11 min tests/ui 📄log
✔️ 70e4b7d #3 2024-03-20 08:16:49 ~17 min linux/x86_64 📦tgz
✔️ 70e4b7d #3 2024-03-20 08:21:16 ~22 min windows/x86_64 💿exe

@@ -60,6 +60,7 @@ Item {
{ text: qsTr("System"), group: ActivityCenterStore.ActivityCenterGroup.System, visible: false, enabled: true } ]

StatusFlatButton {
objectName: "activityCenterButton"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
objectName: "activityCenterButton"
objectName: "activityCenterGroupButton"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Valentina1133 Valentina1133 force-pushed the chore/add_object_name_activity_center branch from 29cccd2 to f0e6b75 Compare March 20, 2024 07:42
@Valentina1133 Valentina1133 force-pushed the chore/add_object_name_activity_center branch from f0e6b75 to 70e4b7d Compare March 20, 2024 07:58
@Valentina1133 Valentina1133 merged commit a48b253 into master Mar 20, 2024
8 checks passed
@Valentina1133 Valentina1133 deleted the chore/add_object_name_activity_center branch March 20, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants