feat(wallet): resize saved address popup to remove network selection #13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanBelyakoff
requested review from
saledjenic,
caybro,
Khushboo-dev-cpp,
alaibe and
Cuteivist
Jenkins BuildsClick to see older builds (18)
|
saledjenic
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
@IvanBelyakoff changes look good, just 2 things:
- we're still unsure whether to add chain prefixes for ens names or not (cause in the end that's just an alias for a real address)
- if we decide to don't add them then we need to update show QR popup similarly to what you did here
IvanBelyakoff
force-pushed
the
feat/saved_address_dialog_resize_on_ens_entered
branch
from
e5384b2
to
3afbe10
Compare
|
@benjthayer maybe you might want to have a look at the animation of hiding the netwroks on video, if it is fine with you. |
caybro
reviewed
Mar 4, 2024
IvanBelyakoff
force-pushed
the
feat/saved_address_dialog_resize_on_ens_entered
branch
2 times, most recently
from
481e475
to
b5221db
Compare
when ENS name is resolved. Resolve ENS name before used in SendModal. UI tweaks: - red stroke on address input in case of error - smaller tick for validation address input - added validation spinner to address input, removed from the button - handled tab key to move focus between inputs
IvanBelyakoff
force-pushed
the
feat/saved_address_dialog_resize_on_ens_entered
branch
from
b5221db
to
09ccf73
Compare
IvanBelyakoff
deleted the
feat/saved_address_dialog_resize_on_ens_entered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ENS name is resolved.
Affected areas
Saved address popup
StatusQ checklist
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-03-05.at.15.09.19.mov
[x ] I've checked the design and this PR matches it
Closed #13381