chore: clean up exception specifiers #13735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotating functions explicitly with `{.raises: [Exception].}` prevents
Nim from performing compile-time exception checking and is almost never
desired - it does have a tendency to spread through the codebase
however, similar to sub-par const correctness in C++.
The reason these annotations might have seemed necessary can be traced
to missing exception specifiers in the go imports bumped in this PR.
See
https://status-im.github.io/nim-style-guide/interop.c.html#functions-and-types
for background on Nim-go interop and
https://status-im.github.io/nim-style-guide/errors.exceptions.html for
more information on how exception tracking can be leveraged to find
missing error handling at compile-time.
This change has no runtime effect - it merely makes compile-time error
messages more informative or avoids them entirely.
Jenkins BuildsClick to see older builds (12)
|
jrainville
approved these changes
Feb 27, 2024
|
ping @jrainville @endulab - this would benefit from a timely merge giving its conflict-proneness |
osmaczko
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotating functions explicitly with
{.raises: [Exception].}prevents Nim from performing compile-time exception checking and is almost never desired - it does have a tendency to spread through the codebase however, similar to sub-par const correctness in C++.The reason these annotations might have seemed necessary can be traced to missing exception specifiers in the go imports bumped in this PR.
See
https://status-im.github.io/nim-style-guide/interop.c.html#functions-and-types for background on Nim-go interop and
https://status-im.github.io/nim-style-guide/errors.exceptions.html for more information on how exception tracking can be leveraged to find missing error handling at compile-time.
This change has no runtime effect - it merely makes compile-time error messages more informative or avoids them entirely.
What does the PR do
Affected areas
StatusQ checklist
Screenshot of functionality (including design for comparison)
Cool Spaceship Picture