-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Profile flow) ID verification flows (incoming/outgoing) #13727
feat(Profile flow) ID verification flows (incoming/outgoing) #13727
Conversation
4925b0f
to
401a10c
Compare
Jenkins BuildsClick to see older builds (44)
|
2440bfb
to
a52c89b
Compare
0be8ad4
to
8160a4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -58,7 +54,7 @@ CommonContactDialog { | |||
|
|||
StatusCheckBox { | |||
id: ctrlRemoveIDVerification | |||
visible: contactDetails.isContact && !d.isTrusted && d.isVerificationRequestReceived | |||
visible: (contactDetails.isContact && d.isTrusted) || contactDetails.trustStatus === Constants.trustStatus.trusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo contactDetails.isContact && d.isTrusted)
is sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wanted to make double sure (also for Storybook) :) It can't hurt and also I wasn't certain how this would get implemented in the end when I started working on this
8160a4c
to
01cc5e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Component.onCompleted: { | ||
Global.userProfile = { | ||
name: "Anna", | ||
pubKey: "Oxdeadbeef", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
What does the PR do
verification flows
Fixes #13709
Fixes #13745
Fixes #13747
Affected areas
ProfileDialogView, ProfileContextMenu
Screenshot of functionality (including design for comparison)
Request/send an ID request:
Reply to incoming ID request:
View pending ID request/reply:
Accept/reject pending ID request: