Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProfileShowcase): Add blur delegate state while dragging #13703

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

noeliaSD
Copy link
Contributor

Closes #13594

What does the PR do

  • Added FastBlur component to ShowcaseDelegate and added property to change to blur state.
  • Updated ProfileShowcasePanel to activate blur delegate state when dragging.

Affected areas

Profile Showcase --> Accounts, communities, assets and collectibles tabs

Screenshot of functionality

  • Storybook:
Screen.Recording.2024-02-23.at.12.22.51.mov
  • App:
Screen.Recording.2024-02-23.at.12.25.21.mov

- Added `FastBlur` component to `ShowcaseDelegate` and added property to change to blur state.
- Updated `ProfileShowcasePanel` to activate blur delegate state when dragging.

Closes #13594
@status-im-auto
Copy link
Member

status-im-auto commented Feb 23, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ab3af89 #1 2024-02-23 11:38:04 ~6 min tests/nim 📄log
✔️ ab3af89 #1 2024-02-23 11:38:25 ~6 min macos/aarch64 🍎dmg
✔️ ab3af89 #1 2024-02-23 11:41:43 ~10 min macos/x86_64 🍎dmg
✔️ ab3af89 #1 2024-02-23 11:42:59 ~11 min tests/ui 📄log
✔️ ab3af89 #1 2024-02-23 11:52:08 ~20 min linux/x86_64 📦tgz
✔️ ab3af89 #1 2024-02-23 12:01:44 ~30 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@noeliaSD noeliaSD merged commit 90f4e14 into master Feb 26, 2024
8 checks passed
@noeliaSD noeliaSD deleted the feat/issue-13594 branch February 26, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile Showcase] Work on the blur delegate state while dragging
4 participants