-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@desktop/wallet): Update token details view #13667
Conversation
Jenkins Builds
|
ee2660c
to
6e6bd47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me 👍
@@ -171,7 +171,7 @@ StatusScrollView { | |||
regexValidator.regularExpression: Constants.regularExpressions.ascii | |||
regexValidator.errorMessage: qsTr("Only A-Z, 0-9 and standard punctuation allowed") | |||
|
|||
onTextChanged: root.token.description | |||
onTextChanged: root.token.description = text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting :)
closes #12373
What does the PR do
Design implemented in this PR: https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21330-199931&mode=design&t=CjaU66KwWS3bRgrp-4
Affected areas
AssetDetailsView
StatusQ checklist
Screenshot of functionality (including design for comparison)
Community Token:
Screen.Recording.2024-02-21.at.6.44.51.PM.mov
ERC20
ethDetails.mov