Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BackupSeedPopup]: Fixed warning message size based on text size #13656

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

alexandraB99
Copy link
Contributor

Closes #8402

What does the PR do

Backup Seed Phrase Popup: Fixed warning message size based on text size

Affected areas

Backup Seed Phrase Popup

Screenshot of functionality (including design for comparison)

wt.mov

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but would be nice to also fix the width/margins, so that the text doesn't go over the scrollbar

@status-im-auto
Copy link
Member

status-im-auto commented Feb 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 40c9f6d #1 2024-02-20 18:35:34 ~6 min macos/aarch64 🍎dmg
✔️ 40c9f6d #1 2024-02-20 18:36:01 ~6 min tests/nim 📄log
✔️ 40c9f6d #1 2024-02-20 18:39:21 ~10 min macos/x86_64 🍎dmg
✔️ 40c9f6d #1 2024-02-20 18:40:10 ~10 min tests/ui 📄log
✔️ 40c9f6d #1 2024-02-20 18:46:11 ~17 min linux/x86_64 📦tgz
✔️ 40c9f6d #1 2024-02-20 19:06:15 ~36 min windows/x86_64 💿exe
✔️ 5871f21 #2 2024-02-21 12:02:11 ~4 min macos/aarch64 🍎dmg
✔️ 5871f21 #2 2024-02-21 12:03:47 ~6 min tests/nim 📄log
✔️ 5871f21 #2 2024-02-21 12:05:42 ~8 min macos/x86_64 🍎dmg
✔️ 5871f21 #2 2024-02-21 12:09:22 ~11 min tests/ui 📄log
✔️ 5871f21 #2 2024-02-21 12:13:49 ~16 min linux/x86_64 📦tgz
✔️ 5871f21 #2 2024-02-21 12:27:06 ~29 min windows/x86_64 💿exe

@alexandraB99
Copy link
Contributor Author

Looks good but would be nice to also fix the width/margins, so that the text doesn't go over the scrollbar

@caybro done

pu

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks very nice now 👍

@alexandraB99 alexandraB99 merged commit 8cdfa81 into master Feb 22, 2024
8 checks passed
@alexandraB99 alexandraB99 deleted the fix/issue-8402 branch February 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings -> Backup seed phrase: warning text background is not resized when using large text size
4 participants