Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(activity): Add navigation to tx details #13634

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Cuteivist
Copy link
Contributor

@Cuteivist Cuteivist commented Feb 20, 2024

Task #13249

status-go change: status-im/status-go#4769

What does the PR do

  • Pass required data to be able to show transaction details
  • Fetch wallet activity until desired transaction data is available

Affected areas

  • Wallet / activity
  • Activity center

Screenshot of functionality (including design for comparison)

move_to_tx_details.mp4

@status-im-auto
Copy link
Member

status-im-auto commented Feb 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7bc8e8a #1 2024-02-20 09:18:14 ~6 min macos/aarch64 🍎dmg
✔️ 7bc8e8a #1 2024-02-20 09:18:27 ~6 min tests/nim 📄log
✔️ 7bc8e8a #1 2024-02-20 09:21:44 ~10 min macos/x86_64 🍎dmg
7bc8e8a #1 2024-02-20 09:22:30 ~10 min tests/ui 📄log
✔️ 7bc8e8a #1 2024-02-20 09:27:52 ~16 min linux/x86_64 📦tgz
✔️ 7bc8e8a #1 2024-02-20 09:36:43 ~25 min windows/x86_64 💿exe
✔️ 667bde9 #2 2024-02-21 12:52:47 ~4 min macos/aarch64 🍎dmg
✔️ 667bde9 #2 2024-02-21 12:54:31 ~6 min tests/nim 📄log
✔️ 667bde9 #2 2024-02-21 12:56:37 ~8 min macos/x86_64 🍎dmg
✔️ 667bde9 #2 2024-02-21 12:58:30 ~10 min tests/ui 📄log
✔️ 667bde9 #2 2024-02-21 13:03:23 ~15 min linux/x86_64 📦tgz
✔️ 667bde9 #2 2024-02-21 13:11:50 ~23 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cuteivist Cuteivist force-pushed the feat/13249-navigate-to-tx-details branch from 7bc8e8a to 667bde9 Compare February 21, 2024 12:48
@Cuteivist Cuteivist merged commit 3126973 into master Feb 22, 2024
8 checks passed
@Cuteivist Cuteivist deleted the feat/13249-navigate-to-tx-details branch February 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants