-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@wallet): Show community activity #13627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
caybro,
IvanBelyakoff,
alexandraB99 and
Khushboo-dev-cpp
February 19, 2024 14:19
Jenkins BuildsClick to see older builds (6)
|
caybro
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor things
Cuteivist
force-pushed
the
feat/13121-community-mint-activity
branch
from
February 21, 2024 13:21
32508e4
to
53044dc
Compare
Cuteivist
force-pushed
the
feat/13121-community-mint-activity
branch
from
February 22, 2024 12:06
53044dc
to
496f42a
Compare
alaibe
approved these changes
Feb 22, 2024
caybro
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #13121
Status-go change:
What does the PR do
Use community ID to display community data in wallet activity delegate
Affected areas
Wallet / activity
Screenshot of functionality (including design for comparison)
2024-02-19_11-07-57.mp4