Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@wallet): Show community activity #13627

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Cuteivist
Copy link
Contributor

Task #13121

Status-go change:

What does the PR do

Use community ID to display community data in wallet activity delegate

Affected areas

Wallet / activity

Screenshot of functionality (including design for comparison)

2024-02-19_11-07-57.mp4

@status-im-auto
Copy link
Member

status-im-auto commented Feb 19, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 32508e4 #1 2024-02-19 14:26:16 ~6 min tests/nim 📄log
✔️ 32508e4 #1 2024-02-19 14:26:33 ~6 min macos/aarch64 🍎dmg
✔️ 32508e4 #1 2024-02-19 14:30:22 ~10 min tests/ui 📄log
✔️ 32508e4 #1 2024-02-19 14:32:06 ~12 min macos/x86_64 🍎dmg
✔️ 32508e4 #1 2024-02-19 14:35:15 ~15 min linux/x86_64 📦tgz
✔️ 32508e4 #1 2024-02-19 14:54:10 ~34 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 53044dc #2 2024-02-21 13:27:56 ~6 min tests/nim 📄log
✔️ 53044dc #2 2024-02-21 13:29:29 ~7 min macos/aarch64 🍎dmg
✔️ 53044dc #2 2024-02-21 13:29:43 ~7 min macos/x86_64 🍎dmg
✔️ 53044dc #2 2024-02-21 13:32:39 ~10 min tests/ui 📄log
✔️ 53044dc #2 2024-02-21 13:37:54 ~16 min linux/x86_64 📦tgz
✔️ 53044dc #2 2024-02-21 13:51:11 ~29 min windows/x86_64 💿exe
✔️ 496f42a #3 2024-02-22 12:12:25 ~5 min macos/aarch64 🍎dmg
✔️ 496f42a #3 2024-02-22 12:12:40 ~5 min tests/nim 📄log
✔️ 496f42a #3 2024-02-22 12:14:32 ~7 min macos/x86_64 🍎dmg
✔️ 496f42a #3 2024-02-22 12:16:52 ~10 min tests/ui 📄log
✔️ 496f42a #3 2024-02-22 12:22:07 ~15 min linux/x86_64 📦tgz
✔️ 496f42a #3 2024-02-22 12:37:43 ~30 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor things

src/app/modules/main/wallet_section/activity/entry.nim Outdated Show resolved Hide resolved
src/app/modules/main/wallet_section/activity/entry.nim Outdated Show resolved Hide resolved
ui/imports/shared/controls/TransactionDelegate.qml Outdated Show resolved Hide resolved
@Cuteivist Cuteivist force-pushed the feat/13121-community-mint-activity branch from 32508e4 to 53044dc Compare February 21, 2024 13:21
@Cuteivist Cuteivist force-pushed the feat/13121-community-mint-activity branch from 53044dc to 496f42a Compare February 22, 2024 12:06
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Cuteivist Cuteivist merged commit fae86bc into master Feb 22, 2024
8 checks passed
@Cuteivist Cuteivist deleted the feat/13121-community-mint-activity branch February 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants