feat(savedaddresses): saved address details popup implementation #13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
saledjenic
force-pushed
the
feat/issue-13096
branch
2 times, most recently
from
9086a1a
to
5020fb8
Compare
saledjenic
requested review from
alaibe,
dlipicar,
Cuteivist and
Khushboo-dev-cpp
|
This PR misses just one tiny UI feature, but that should be implemented globally as a functionality of the When the user is scrolling up and the list starts moving over "Send" button and address component in the attached video above, we're displaying the address and "Send" button in the header as the list moves up. But @benjthayer suggested animating the display of the address in the header as well, like in the video below, that's something we need to implement in a new issue. Anim2.movUI team @alexandraB99 |
saledjenic
force-pushed
the
feat/issue-13096
branch
from
5020fb8
to
b2d5c84
Compare
Within this commit a new popup is introduced with the requested UI effect. Closes #13096
saledjenic
force-pushed
the
feat/issue-13096
branch
from
b2d5c84
to
49754e3
Compare
alaibe
approved these changes
Feb 22, 2024
IvanBelyakoff
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM.
I see you faced sections issue. I think this now became a more general issue for the whole team - how to hide/show sections and make it reliable. I think we need a component for that. Maybe we should edit StatusListItem to implement something like what you did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this commit a new popup is introduced with the requested UI effect.
Closes #13096
This is how a new UI effect works, the request was when scroll activity moves over send button and eth address, then eth address and send button appear in the header. Now if we have a good component that will display history TXs for the provided address we would just replace those rectangles and an entire feature would be completed in a few more lines.
SavedAddressesDetails.mov