-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ProfileShowcase): Add foldable sections in all needed settings tabs #13592
Conversation
…om wallet to shared Renamed `ManageTokensListViewBase` to `EmptyShapeRectangleFooterListView` and moved `FoldableHeader` to shared/controls. Updated related `ManageXXPanel` components.
Removed unnecessary `ColumnLayout` and adjusted sizing of component inside.
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just one minor observation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Modified `ProfileShowcasePanel` with 2 foldable sections. - Modified api of `ProfileShowcaseCommunitiesPanel` with the new base component. - Modified api of `ProfileShowcaseAccountsPanel` with the new base component. - Modified api of `ProfileShowcaseAssetsPanel` and `ProfileShowcaseCollectiblesPanel` with the new base component. - Added needed `storybook` support. Closes of #13504
05b98e3
to
88854a2
Compare
Closes #13504
What does the PR do
ProfileShowcaseBasePanel
with 2 foldable sections.ProfileShowcaseXXXPanel
with the new base component (communities, accounts, assets and collectibles).storybook
support.NOTES:
EmptyShapeRectangleFooterListView
contains a new propertyempty
that must be removed when refactor of the hidden / showcase models are done in [Profile Showcase]: simplify API ofProfileShowcase*Panel
tabs #13498app
are not working properly in some occasions due to how the models are threated now. Same thing than the previous one, with the models refactor, it will be solved.Affected areas
Profile showcase tabs: Accounts, Communities, Collectibles and Assets
Screenshot of functionality
Screen.Recording.2024-02-15.at.18.17.17.mov
Screen.Recording.2024-02-15.at.19.24.12.mov
Screen.Recording.2024-02-16.at.09.42.03.mov