-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(desktop/fix) Fix missing crown after ownership transfer #13587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounkou
commented
Feb 16, 2024
Jenkins BuildsClick to see older builds (18)
|
After updating current development branch with latest, I can't Finalize Ownership transfer flow. I am seeing a endless loading icon. |
kounkou
force-pushed
the
fix-missing-crown-after-ownership-transfer
branch
from
February 16, 2024 06:24
3c8a0c5
to
19ce177
Compare
endulab
suggested changes
Feb 19, 2024
kounkou
force-pushed
the
fix-missing-crown-after-ownership-transfer
branch
2 times, most recently
from
February 21, 2024 20:48
3242f64
to
65d6122
Compare
MishkaRogachev
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
kounkou
force-pushed
the
fix-missing-crown-after-ownership-transfer
branch
from
February 22, 2024 19:01
65d6122
to
ad272ec
Compare
endulab
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the missing crown problem after an ownership transfer
fixes #13218 #13218
What does the PR do
The PR triggers the update of the memberRole property in the user model to be able to update the presence of a crown on a member.
Affected areas
Screenshot of functionality (including design for comparison)
solution-missing-crown.webm