Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(desktop/fix) Fix missing crown after ownership transfer #13587

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

kounkou
Copy link
Contributor

@kounkou kounkou commented Feb 16, 2024

Description

This PR solves the missing crown problem after an ownership transfer

fixes #13218 #13218

What does the PR do

The PR triggers the update of the memberRole property in the user model to be able to update the presence of a crown on a member.

Affected areas

  • Chat

Screenshot of functionality (including design for comparison)

solution-missing-crown.webm

@kounkou kounkou self-assigned this Feb 16, 2024
@kounkou kounkou requested a review from endulab February 16, 2024 02:34
@status-im-auto
Copy link
Member

status-im-auto commented Feb 16, 2024

Jenkins Builds

Click to see older builds (18)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3c8a0c5 #1 2024-02-16 02:40:25 ~5 min tests/nim 📄log
✔️ 3c8a0c5 #1 2024-02-16 02:41:09 ~6 min macos/aarch64 🍎dmg
✔️ 3c8a0c5 #1 2024-02-16 02:44:50 ~10 min tests/ui 📄log
✔️ 3c8a0c5 #1 2024-02-16 02:46:49 ~12 min macos/x86_64 🍎dmg
✔️ 3c8a0c5 #1 2024-02-16 02:51:06 ~16 min linux/x86_64 📦tgz
✔️ 3c8a0c5 #1 2024-02-16 03:10:11 ~35 min windows/x86_64 💿exe
✔️ 19ce177 #2 2024-02-16 06:29:37 ~4 min macos/aarch64 🍎dmg
✔️ 19ce177 #2 2024-02-16 06:30:49 ~5 min tests/nim 📄log
✔️ 19ce177 #2 2024-02-16 06:32:48 ~7 min macos/x86_64 🍎dmg
✔️ 19ce177 #2 2024-02-16 06:35:16 ~10 min tests/ui 📄log
✔️ 19ce177 #2 2024-02-16 06:42:13 ~17 min linux/x86_64 📦tgz
✔️ 19ce177 #2 2024-02-16 06:51:21 ~26 min windows/x86_64 💿exe
✔️ 3242f64 #3 2024-02-21 20:20:44 ~4 min macos/aarch64 🍎dmg
✔️ 3242f64 #3 2024-02-21 20:22:35 ~6 min tests/nim 📄log
✔️ 3242f64 #3 2024-02-21 20:23:48 ~7 min macos/x86_64 🍎dmg
✔️ 3242f64 #3 2024-02-21 20:27:16 ~11 min tests/ui 📄log
✔️ 3242f64 #3 2024-02-21 20:31:35 ~15 min linux/x86_64 📦tgz
✔️ 3242f64 #3 2024-02-21 20:46:59 ~31 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 65d6122 #4 2024-02-21 20:52:35 ~4 min macos/aarch64 🍎dmg
✔️ 65d6122 #4 2024-02-21 20:54:38 ~6 min tests/nim 📄log
✔️ 65d6122 #4 2024-02-21 20:57:02 ~8 min macos/x86_64 🍎dmg
✔️ 65d6122 #4 2024-02-21 20:58:55 ~10 min tests/ui 📄log
✔️ 65d6122 #4 2024-02-21 21:03:59 ~15 min linux/x86_64 📦tgz
✔️ 65d6122 #4 2024-02-21 21:14:13 ~25 min windows/x86_64 💿exe
✔️ ad272ec #5 2024-02-22 19:06:32 ~4 min macos/aarch64 🍎dmg
✔️ ad272ec #5 2024-02-22 19:07:27 ~5 min tests/nim 📄log
✔️ ad272ec #5 2024-02-22 19:10:49 ~9 min macos/x86_64 🍎dmg
✔️ ad272ec #5 2024-02-22 19:12:08 ~10 min tests/ui 📄log
✔️ ad272ec #5 2024-02-22 19:15:14 ~13 min linux/x86_64 📦tgz
✔️ ad272ec #5 2024-02-22 19:34:48 ~33 min windows/x86_64 💿exe

@kounkou kounkou removed the request for review from endulab February 16, 2024 02:53
@kounkou
Copy link
Contributor Author

kounkou commented Feb 16, 2024

After updating current development branch with latest, I can't Finalize Ownership transfer flow. I am seeing a endless loading icon.
Seems related to : #13546

Screenshot from 2024-02-15 21-55-59

@kounkou kounkou force-pushed the fix-missing-crown-after-ownership-transfer branch from 3c8a0c5 to 19ce177 Compare February 16, 2024 06:24
@kounkou kounkou requested a review from endulab February 16, 2024 06:33
@kounkou kounkou force-pushed the fix-missing-crown-after-ownership-transfer branch 2 times, most recently from 3242f64 to 65d6122 Compare February 21, 2024 20:48
@kounkou kounkou requested a review from endulab February 21, 2024 20:52
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/app_service/service/community/service.nim Outdated Show resolved Hide resolved
src/app_service/service/community/service.nim Outdated Show resolved Hide resolved
This PR solves the missing crown problem after an ownership transfer

fixes #13218 #13218
@kounkou kounkou force-pushed the fix-missing-crown-after-ownership-transfer branch from 65d6122 to ad272ec Compare February 22, 2024 19:01
@kounkou kounkou merged commit 7313e22 into master Feb 23, 2024
8 checks passed
@kounkou kounkou deleted the fix-missing-crown-after-ownership-transfer branch February 23, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no crown for the new community owner after the community transfership
4 participants