-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@desktop/settings): Integrate token advanced settings with backend #13487
Conversation
Jenkins BuildsClick to see older builds (26)
|
ad8df75
to
52be63c
Compare
@Cuteivist can you please rebase so tests can pass? there were some UI changes merged recently |
52be63c
to
bdcda4c
Compare
its all green now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! I've just added a question for Ben
.
I'd also like to test it. @Cuteivist could you rebase on top of master? I cannot test it now bc there was a bug on master yesterday that doesn't allow to save changes using the dirty toast message!
bdcda4c
to
d7f219e
Compare
@noeliaSD Code is rebased to newest master. To properly get it working you need to rebase status-go to |
d7f219e
to
3991e9f
Compare
3991e9f
to
9068cb7
Compare
Task #13178
What does the PR do
CurrencyAmount
as Controller variable because it was removed by garbage collectorAffected areas
Settings / Token Management / Advanced
Screenshot of functionality (including design for comparison)
2024-02-09_11-36-06.mp4