Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13335 profile showcase identity update display name error messages #13440

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Feb 7, 2024

What does the PR do

Closing: #13335

Changes:

  1. Update error messages in the display name validators

Affected areas

Profile settings
Display name validators

Screenshot of functionality (including design for comparison)

Screen.Recording.2024-02-14.at.14.23.52.mov

@alexjba alexjba linked an issue Feb 7, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Feb 7, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3c09d14 #1 2024-02-07 08:29:03 ~6 min tests/nim 📄log
✔️ 3c09d14 #1 2024-02-07 08:29:33 ~6 min macos/aarch64 🍎dmg
✔️ 3c09d14 #1 2024-02-07 08:33:05 ~10 min macos/x86_64 🍎dmg
✔️ 3c09d14 #1 2024-02-07 08:33:54 ~10 min tests/ui 📄log
✔️ 3c09d14 #1 2024-02-07 08:39:23 ~16 min linux/x86_64 📦tgz
✔️ 3c09d14 #1 2024-02-07 08:48:57 ~25 min windows/x86_64 💿exe
✖️ 3c09d14 #1 2024-02-07 08:54:52 ~31 min tests/e2e 📄log
✔️ 234aeae #2 2024-02-14 12:30:58 ~5 min tests/nim 📄log
✔️ 234aeae #2 2024-02-14 12:31:23 ~6 min macos/aarch64 🍎dmg
✔️ 234aeae #2 2024-02-14 12:35:32 ~10 min macos/x86_64 🍎dmg
✔️ 234aeae #2 2024-02-14 12:35:40 ~10 min tests/ui 📄log
✔️ 234aeae #2 2024-02-14 12:39:23 ~14 min linux/x86_64 📦tgz
✔️ 234aeae #2 2024-02-14 12:47:20 ~22 min windows/x86_64 💿exe

@alexjba alexjba force-pushed the 13335-profile-showcase-identity-update-display-name-error-messages branch from 3c09d14 to 234aeae Compare February 14, 2024 12:24
@alexjba alexjba marked this pull request as ready for review February 14, 2024 12:26
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexjba alexjba merged commit 610a9dc into master Feb 16, 2024
8 checks passed
@alexjba alexjba deleted the 13335-profile-showcase-identity-update-display-name-error-messages branch February 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Profile Showcase - Identity] Update Display name error messages
4 participants