Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show activity center notification if user must reveal addressed to join/rejoin the community #12856

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: show activity center notification if user must reveal addressed to join/rejoin the community #12856

merged 2 commits into from
Nov 28, 2023

Conversation

mprakhov
Copy link
Contributor

@mprakhov mprakhov commented Nov 23, 2023 •
edited
Loading

What does the PR do

When the community ownership changed, all members are kicked. If this member does not have request to join with revealed addresses or revealed addresses is not signed - show the a notification in activity center to share their revealed accounts

Closes: #11974

status-go PR: status-im/status-go#4373

Screen.Recording.2023-11-24.at.12.31.54.mov

@mprakhov mprakhov requested review from a team, kounkou, iurimatias, jrainville and osmaczko and removed request for a team November 23, 2023 17:15
@mprakhov mprakhov mentioned this pull request Nov 23, 2023
Merged
@mprakhov
Copy link
Contributor Author

@jrainville this is the PR I'm waiting for a UI review.

P.S. I think it would be good to put it into RC 0.15.x as it has some critical fixes on status-go side

@status-im-auto
Copy link
Member

status-im-auto commented Nov 23, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (28)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 43982ae #1 2023-11-23 17:23:23 ~7 min tests/nim 📄log
✔️ 43982ae #1 2023-11-23 17:24:29 ~8 min macos/aarch64 🍎dmg
✔️ 43982ae #1 2023-11-23 17:26:54 ~10 min macos/x86_64 🍎dmg
✔️ d50edfb #3 2023-11-23 17:46:49 ~7 min macos/aarch64 🍎dmg
✔️ d50edfb #3 2023-11-23 17:51:24 ~12 min tests/ui 📄log
✔️ d50edfb #3 2023-11-23 17:51:49 ~12 min macos/x86_64 🍎dmg
✔️ d50edfb #3 2023-11-23 17:53:39 ~14 min tests/nim 📄log
✔️ 2e2c284 #4 2023-11-23 18:02:55 ~5 min macos/aarch64 🍎dmg
✔️ 2e2c284 #4 2023-11-23 18:06:06 ~8 min macos/x86_64 🍎dmg
✔️ 2e2c284 #4 2023-11-23 18:07:49 ~10 min tests/nim 📄log
✔️ 2e2c284 #4 2023-11-23 18:13:34 ~16 min linux/x86_64 📦tgz
✖️ 2e2c284 #4 2023-11-23 18:18:10 ~20 min tests/e2e 📄log
✔️ 2e2c284 #4 2023-11-23 18:18:54 ~21 min windows/x86_64 💿exe
✔️ 2e2c284 #4 2023-11-23 18:34:28 ~37 min tests/ui 📄log
✔️ 6fcd3fc #5 2023-11-24 11:36:25 ~5 min macos/aarch64 🍎dmg
✔️ 6fcd3fc #5 2023-11-24 11:39:45 ~8 min macos/x86_64 🍎dmg
✔️ 6fcd3fc #5 2023-11-24 11:52:54 ~21 min windows/x86_64 💿exe
✔️ 6fcd3fc #5 2023-11-24 12:14:01 ~42 min tests/nim 📄log
✔️ 6fcd3fc #5 2023-11-24 12:49:07 ~1 hr 17 min tests/ui 📄log
✖️ 6fcd3fc #5 2023-11-24 13:13:16 ~1 hr 42 min tests/e2e 📄log
✔️ 63cc59a #6 2023-11-27 10:08:52 ~5 min macos/aarch64 🍎dmg
✔️ 44682ec #7 2023-11-27 10:14:04 ~4 min macos/aarch64 🍎dmg
✔️ 44682ec #7 2023-11-27 10:17:23 ~8 min tests/nim 📄log
✔️ 44682ec #7 2023-11-27 10:19:17 ~10 min tests/ui 📄log
✔️ 44682ec #7 2023-11-27 10:22:22 ~13 min macos/x86_64 🍎dmg
✔️ 44682ec #7 2023-11-27 10:28:05 ~18 min linux/x86_64 📦tgz
✔️ 44682ec #7 2023-11-27 10:39:03 ~29 min windows/x86_64 💿exe
✖️ 44682ec #7 2023-11-27 10:55:58 ~46 min tests/e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ab16dc2 #8 2023-11-27 13:53:12 ~5 min macos/aarch64 🍎dmg
✔️ ab16dc2 #8 2023-11-27 13:53:48 ~6 min tests/nim 📄log
✔️ ab16dc2 #8 2023-11-27 13:56:13 ~8 min macos/x86_64 🍎dmg
✔️ ab16dc2 #8 2023-11-27 13:58:40 ~11 min tests/ui 📄log
✔️ ab16dc2 #8 2023-11-27 14:02:53 ~15 min linux/x86_64 📦tgz
✔️ ab16dc2 #8 2023-11-27 14:09:36 ~22 min windows/x86_64 💿exe
✖️ ab16dc2 #8 2023-11-27 14:09:42 ~22 min tests/e2e 📄log
✔️ 3490c80 #9 2023-11-28 12:19:56 ~5 min macos/aarch64 🍎dmg
✔️ 3490c80 #9 2023-11-28 12:21:36 ~7 min tests/nim 📄log
✔️ 3490c80 #9 2023-11-28 12:23:10 ~9 min macos/x86_64 🍎dmg
✔️ 3490c80 #9 2023-11-28 12:25:21 ~11 min tests/ui 📄log
✔️ 3490c80 #9 2023-11-28 12:32:59 ~18 min linux/x86_64 📦tgz
✔️ 3490c80 #9 2023-11-28 12:40:07 ~25 min windows/x86_64 💿exe
✔️ 3490c80 #9 2023-11-28 12:44:54 ~30 min tests/e2e 📄log

jrainville
jrainville reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Just copy suggestions.

I think it would be good to put it into RC 0.15.x as it has some critical fixes on status-go side

The changes don't seem to introduce regressions, so it's fine to put it in the release if you think it fixes issues.

ui/app/mainui/Popups.qml Outdated Show resolved Hide resolved
ui/app/mainui/Popups.qml Outdated Show resolved Hide resolved
ui/app/mainui/activitycenter/views/ActivityNotificationCommunityShareAddresses.qml Outdated Show resolved Hide resolved
ui/app/mainui/activitycenter/views/ActivityNotificationCommunityShareAddresses.qml Outdated Show resolved Hide resolved
@mprakhov
Copy link
Contributor Author

updated result in the PR description

caybro
caybro approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jrainville
jrainville approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@John-44 John-44 added this to the 0.15.0 RC milestone Nov 27, 2023
@jakubgs
Copy link
Member

jakubgs commented Nov 27, 2023

The app from this PR appears to be segfaulting:

Traceback (most recent call last)
/home/jenkins/workspace/rs_linux_x86_64_package_PR-12856@2/src/nim_status_client.nim(208) nim_status_client
/home/jenkins/workspace/rs_linux_x86_64_package_PR-12856@2/src/nim_status_client.nim(181) mainProc
/home/jenkins/workspace/rs_linux_x86_64_package_PR-12856@2/src/app/boot/app_controller.nim(298) delete
/home/jenkins/workspace/rs_linux_x86_64_package_PR-12856@2/src/app/modules/startup/io_interface.nim(19) delete
/home/jenkins/workspace/rs_linux_x86_64_package_PR-12856@2/src/app/modules/startup/module.nim(87) delete
/home/jenkins/workspace/rs_linux_x86_64_package_PR-12856@2/vendor/nimqml/src/nimqml/private/qqmlapplicationengine.nim(29) setRootContextProperty
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

@jakubgs jakubgs mentioned this pull request Nov 27, 2023
Open
@jakubgs
Copy link
Member

jakubgs commented Nov 27, 2023

Actually, this might be a red herring and the issue is already in master.

@mprakhov
Copy link
Contributor Author

Actually, this might be a red herring and the issue is already in master.

Looking, it seems something stopped to work after the rebase

@mprakhov
Copy link
Contributor Author

ok, I think I found the problem, StatusTimeStampLabel.qml was moved to another place

@jakubgs jakubgs mentioned this pull request Nov 27, 2023
Closed
@mprakhov
Copy link
Contributor Author

@jakubgs - could you please check what can be wrong now? Locally it is working

@jakubgs
Copy link
Member

jakubgs commented Nov 27, 2023

If it's not crashing at startup then it's probably fixed. Please update this issue:

@mprakhov mprakhov merged commit 3af73a4 into master Nov 28, 2023
8 of 9 checks passed
@mprakhov mprakhov deleted the mp/issue-11974 branch November 28, 2023 13:41
mprakhov added a commit that referenced this pull request Nov 28, 2023
@mprakhov
feat: show activity center notification if user must reveal addressed…
9370a3c 
… to join/rejoin the community (#12856)
mprakhov added a commit that referenced this pull request Nov 28, 2023
@mprakhov
feat: show activity center notification if user must reveal addressed…
bf4f4e0 
… to join/rejoin the community (#12856)
jrainville pushed a commit that referenced this pull request Nov 28, 2023
@mprakhov @jrainville
feat: show activity center notification if user must reveal addressed…
154492e 
… to join/rejoin the community (#12856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@jrainville jrainville jrainville approved these changes

@kounkou kounkou Awaiting requested review from kounkou kounkou was automatically assigned from status-im/desktop

@iurimatias iurimatias Awaiting requested review from iurimatias iurimatias was automatically assigned from status-im/desktop-devs

@osmaczko osmaczko Awaiting requested review from osmaczko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0 RC
6 participants
@mprakhov @status-im-auto @jakubgs @caybro @jrainville @John-44