fix(Windows): unbreak Windows build #12840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a feeble attempt to make M$ compiler grok otherwise valid C++17 code
Jenkins Builds
|
caybro
force-pushed
the
12839-windows-build-is-broken
branch
from
20282ba
to
ba752fc
Compare
micieslak
approved these changes
Nov 23, 2023
Yeah, feel free to experiment with the cmake options/switches... I failed :/ Maybe the MSVC compiler version is simply too old, dunno. What version are we using here @jakubgs ? |
anastasiyaig
approved these changes
Nov 23, 2023
|
@caybro you can look those things up yourself in: |
Thanks, seems to be "14.29.30133" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a feeble attempt to make M$ compiler grok otherwise valid C++17 code
What does the PR do
Unbreaks Windows build