Add Deleted message #12804
Add Deleted message #12804
Conversation
Jenkins BuildsClick to see older builds (21)
|
| opacity: 0.1 | ||
| Layout.alignment: Qt.AlignVCenter | ||
|
|
||
| StatusIcon { |
There was a problem hiding this comment.
Looks to me like the mobile icon opacity is 1. Or at least greater that 0.1
The mobile design looks better 😄
| color: Theme.palette.dangerColor1 | ||
| opacity: 0.1 |
There was a problem hiding this comment.
| color: Theme.palette.dangerColor1 | |
| opacity: 0.1 | |
| color: Theme.palette.dangerColor3 |
jrainville
force-pushed
the
feat/deleted-system-message
branch
from
20fbeb0
to
83458bf
Compare
|
@alexjba nice eye. I did find that my icon was hard to see. I forgot that setting opacity on a parent also affects the children 🤦 |
|
|
||
| # messages are sorted from the most recent to the least recent one | ||
| viewItems.add(item) | ||
| var viewItems = self.createMessageItemsFromMessageDtos(messages, reactions) |
| Component { | ||
| id: deletedMessageComponent | ||
|
|
||
| ColumnLayout { |
There was a problem hiding this comment.
This ColumnLayout seems redundant
There was a problem hiding this comment.
Maybe I'm just a QML noob, but without it, the Layout. properties in the RowLayout didn't work. I think it's because the parent of deletedMessageComponent's Loader is not a Layout.
There was a problem hiding this comment.
Yeah... it's weird to have Loader as the toplevel item, you never know in which context the component ends up being used
There was a problem hiding this comment.
Ok I see, it indeed will do the trick here. It's not right, but shouldn't hurt, so I guess we can keep it as it will be rewritten anyway 🙂
|
|
||
| RowLayout { | ||
| id: deletedMessage | ||
| height: 40 |
There was a problem hiding this comment.
I think we shouldn't set height here, it should be calculated automatically based on content size and given margins.
There was a problem hiding this comment.
This component is meant to be removed/refactored by actual good UI devs when we get a design someday 😅
| } | ||
|
|
||
| Rectangle { | ||
| width: deletedMessage.height |
There was a problem hiding this comment.
This should be either implicit... or Layout.preferred..., it's wrong to set width/height for items inside a Layout.
Same for items below
| if result.deleted and result.deletedBy == "": | ||
| # The message was deleted by the sender itself | ||
| result.deletedBy = result.`from` |
There was a problem hiding this comment.
Is the following code needed then 🤔
There was a problem hiding this comment.
Yes, because that code in onMessageDeleted is called from a status-go signal that only contains the messageID, the chatID and possibly the deletedBy (see RemovedMessageDto).
jrainville
force-pushed
the
feat/deleted-system-message
branch
from
83458bf
to
6533457
Compare
jrainville
force-pushed
the
feat/deleted-system-message
branch
from
da119d2
to
21c50c7
Compare
Fixes #11712
Adds a little message when someone deletes a message and shows who deleted.
Do note: there is no Desktop design for this, so I just copied the mobile design. We can modify it once we have an actual design.
delete.webm
^user on the left, group admin on the right (he can delete other people's messages)