Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump status-go #12803

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore: bump status-go #12803

merged 1 commit into from
Nov 21, 2023

Conversation

osmaczko
Copy link
Contributor

Fixes always visible "sending..." message annotation.

Fixes always visible "sending..." message annotation.
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue in the end? I'm curious as it was a weird issue.

@osmaczko
Copy link
Contributor Author

What was the issue in the end? I'm curious as it was a weird issue.

status-im/status-go#4346

Message tracking wasn't working due to my oversight. Instead of allocating space for message hashes, I created them in place and then appended them, resulting in slices like 0, 0x1234. Evidently, the first element in the slice is invalid, which caused the message tracking to fail.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 20, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 519016b #1 2023-11-20 20:40:57 ~6 min tests/nim 📄log
✔️ 519016b #1 2023-11-20 20:42:47 ~8 min macos/aarch64 🍎dmg
✔️ 519016b #1 2023-11-20 20:44:45 ~10 min tests/ui 📄log
✔️ 519016b #1 2023-11-20 20:45:09 ~10 min macos/x86_64 🍎dmg
✔️ 519016b #1 2023-11-20 20:50:28 ~15 min linux/x86_64 📦tgz
✔️ 519016b #1 2023-11-20 21:06:43 ~32 min tests/e2e 📄log
✔️ 519016b #1 2023-11-20 21:07:46 ~33 min windows/x86_64 💿exe

@osmaczko
Copy link
Contributor Author

@jrainville is there an issue I can link this PR to?

@jrainville
Copy link
Member

I don't think we opened one for that. There was this in mobile 😄 status-im/status-mobile#16873 (comment)

@osmaczko osmaczko merged commit 6728006 into master Nov 21, 2023
8 of 9 checks passed
@osmaczko osmaczko deleted the fix/msgs-sending-annotation branch November 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants