Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/nim build warnings #12796

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Chore/nim build warnings #12796

merged 6 commits into from
Nov 20, 2023

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Nov 20, 2023 •
edited
Loading

What does the PR do

Fix more warnings in status-desktop build log.
1335 → 83 lines 😱

Review by commits:

@status-im-auto
Copy link
Member

status-im-auto commented Nov 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (29)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5112d34 #1 2023-11-20 11:17:48 ~7 min tests/nim 📄log
✔️ 5112d34 #1 2023-11-20 11:19:11 ~8 min macos/aarch64 🍎dmg
❌ 5112d34 #1 2023-11-20 11:19:17 ~8 min macos/x86_64 📄log
✔️ 5112d34 #1 2023-11-20 11:21:44 ~11 min tests/ui 📄log
❌ 5112d34 #1 2023-11-20 11:24:31 ~13 min windows/x86_64 📄log
✔️ 5112d34 #1 2023-11-20 11:30:30 ~20 min linux/x86_64 📦tgz
✔️ 5112d34 #1 2023-11-20 11:46:54 ~36 min tests/e2e 📄log
❌ 647deae #2 2023-11-20 11:56:24 ~15 sec macos/x86_64 📄log
❌ 647deae #2 2023-11-20 11:56:46 ~37 sec windows/x86_64 📄log
✖️ 647deae #2 2023-11-20 11:56:58 ~56 sec tests/e2e 📄log
❌ 647deae #3 2023-11-20 11:58:17 ~15 sec macos/x86_64 📄log
❌ 647deae #2 2023-11-20 11:59:12 ~3 min linux/x86_64 📄log
❌ 647deae #2 2023-11-20 11:59:12 ~3 min tests/ui 📄log
✖️ 647deae #2 2023-11-20 11:59:13 ~3 min tests/nim 📄log
❌ 647deae #2 2023-11-20 11:59:45 ~3 min macos/aarch64 📄log
❌ 4b3ccf3 #4 2023-11-20 12:06:13 ~5 min macos/x86_64 📄log
✔️ 4b3ccf3 #3 2023-11-20 12:06:41 ~5 min macos/aarch64 🍎dmg
✔️ 4b3ccf3 #3 2023-11-20 12:07:30 ~6 min tests/nim 📄log
❌ 4b3ccf3 #3 2023-11-20 12:07:42 ~6 min windows/x86_64 📄log
✔️ 4b3ccf3 #3 2023-11-20 12:12:21 ~11 min tests/ui 📄log
✔️ 4b3ccf3 #3 2023-11-20 12:16:05 ~15 min linux/x86_64 📦tgz
✔️ 4b3ccf3 #3 2023-11-20 12:33:57 ~33 min tests/e2e 📄log
✔️ b7ee681 #4 2023-11-20 13:54:42 ~5 min macos/aarch64 🍎dmg
✔️ b7ee681 #4 2023-11-20 13:55:54 ~6 min tests/nim 📄log
✔️ b7ee681 #5 2023-11-20 13:57:01 ~7 min macos/x86_64 🍎dmg
❌ b7ee681 #4 2023-11-20 13:57:19 ~8 min windows/x86_64 📄log
✔️ b7ee681 #4 2023-11-20 14:01:00 ~11 min tests/ui 📄log
✔️ b7ee681 #4 2023-11-20 14:04:43 ~15 min linux/x86_64 📦tgz
✖️ b7ee681 #4 2023-11-20 14:11:20 ~22 min tests/e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 274be39 #5 2023-11-20 14:22:31 ~5 min macos/aarch64 🍎dmg
✔️ 274be39 #5 2023-11-20 14:23:46 ~6 min tests/nim 📄log
❌ 274be39 #5 2023-11-20 14:24:21 ~6 min windows/x86_64 📄log
✔️ 274be39 #6 2023-11-20 14:25:15 ~7 min macos/x86_64 🍎dmg
✔️ 274be39 #5 2023-11-20 14:29:36 ~12 min tests/ui 📄log
✔️ 274be39 #5 2023-11-20 14:32:49 ~15 min linux/x86_64 📦tgz
✔️ 274be39 #5 2023-11-20 14:48:52 ~31 min tests/e2e 📄log
✔️ 71ae00b #6 2023-11-20 15:30:11 ~5 min macos/aarch64 🍎dmg
✔️ 71ae00b #6 2023-11-20 15:30:58 ~6 min tests/nim 📄log
✔️ 71ae00b #7 2023-11-20 15:32:04 ~7 min macos/x86_64 🍎dmg
✔️ 71ae00b #6 2023-11-20 15:36:33 ~12 min tests/ui 📄log
✔️ 71ae00b #6 2023-11-20 15:39:31 ~15 min linux/x86_64 📦tgz
✔️ 71ae00b #6 2023-11-20 15:55:09 ~30 min tests/e2e 📄log
✔️ 71ae00b #6 2023-11-20 16:00:32 ~35 min windows/x86_64 💿exe

@caybro
Copy link
Member

caybro commented Nov 20, 2023

The windows build fails with:

cl : Command line error D8021: invalid numeric argument '/Wno-deprecated' [C:\Users\jenkins\workspace\_windows_x86_64_package_PR-12796\vendor\DOtherSide\build\CMakeFiles\CMakeScratch\TryCompile-dyevtl\cmTC_38b2e.vcxproj]

and the macOS build failure looks also related to this PR (unable to find pcre and openssl dev libs)

@igor-sirotin
Copy link
Contributor Author

The windows build fails with:

cl : Command line error D8021: invalid numeric argument '/Wno-deprecated' [C:\Users\jenkins\workspace\_windows_x86_64_package_PR-12796\vendor\DOtherSide\build\CMakeFiles\CMakeScratch\TryCompile-dyevtl\cmTC_38b2e.vcxproj]

and the macOS build failure looks also related to this PR (unable to find pcre and openssl dev libs)

Sure, I'm aware of that. First fix is already pushed, I'll check if it doesn't help.
Meanwhile the PR can be reviewed anyway 🙂

caybro
caybro reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM :)

Makefile Show resolved Hide resolved
@caybro
Copy link
Member

caybro commented Nov 20, 2023

The win build fails with: c1xx : fatal error C1083: Cannot open source file: 'C:/ProgramData/scoop/apps/git/2.41.0.windows.1/wd4996': No such file or directory [C:\Users\jenkins\workspace\_windows_x86_64_package_PR-12796\vendor\DOtherSide\build\CMakeFiles\CMakeScratch\TryCompile-j14lw3\cmTC_02698.vcxproj]

osmaczko
osmaczko approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/app/modules/main/module.nim Show resolved Hide resolved
@igor-sirotin igor-sirotin force-pushed the chore/nim-build-warnings branch 2 times, most recently from b7ee681 to 274be39 Compare November 20, 2023 14:17
jrainville
jrainville approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@igor-sirotin igor-sirotin merged commit a2e8655 into master Nov 20, 2023
8 of 9 checks passed
@igor-sirotin igor-sirotin deleted the chore/nim-build-warnings branch November 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro left review comments

@jrainville jrainville jrainville approved these changes

@osmaczko osmaczko osmaczko approved these changes

@stefandunca stefandunca Awaiting requested review from stefandunca

@endulab endulab Awaiting requested review from endulab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igor-sirotin @status-im-auto @caybro @jrainville @osmaczko