Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nim unused imports #12783

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

igor-sirotin
Copy link
Contributor

There're 4 warning left in logs. Those are false-warns, these imports are actually used.

/Users/igorsirotin/Repositories/Status/status-desktop/src/app/modules/shared_modules/keycard_popup/module.nim(8, 51) Warning: imported and not used: 'atc' [UnusedImport]
/Users/igorsirotin/Repositories/Status/status-desktop/src/app/modules/startup/module.nim(9, 18) Warning: imported and not used: 'main_constants' [UnusedImport]
/Users/igorsirotin/Repositories/Status/status-desktop/src/app/modules/startup/module.nim(11, 46) Warning: imported and not used: 'atc' [UnusedImport]
/Users/igorsirotin/Repositories/Status/status-desktop/src/app/modules/shared_modules/add_account/module.nim(15, 38) Warning: imported and not used: 'account_constants' [UnusedImport]

@igor-sirotin igor-sirotin self-assigned this Nov 17, 2023
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's something I wanted to do for a while. Those were annoying

@status-im-auto
Copy link
Member

status-im-auto commented Nov 17, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 265a31b #1 2023-11-17 15:55:24 ~6 min tests/nim 📄log
✔️ 265a31b #1 2023-11-17 15:58:33 ~9 min macos/aarch64 🍎dmg
✔️ 265a31b #1 2023-11-17 15:59:43 ~10 min macos/x86_64 🍎dmg
✔️ 265a31b #1 2023-11-17 16:01:49 ~12 min tests/ui 📄log
✔️ 265a31b #1 2023-11-17 16:03:53 ~15 min linux/x86_64 📦tgz
✔️ 265a31b #1 2023-11-17 16:16:55 ~28 min windows/x86_64 💿exe
✔️ 265a31b #1 2023-11-17 16:23:35 ~34 min tests/e2e 📄log
✔️ e837a48 #2 2023-11-17 16:41:27 ~5 min macos/aarch64 🍎dmg
✔️ e837a48 #2 2023-11-17 16:42:18 ~6 min tests/nim 📄log
✔️ e837a48 #2 2023-11-17 16:44:47 ~8 min macos/x86_64 🍎dmg
✔️ e837a48 #2 2023-11-17 16:48:02 ~12 min tests/ui 📄log
✔️ e837a48 #2 2023-11-17 16:50:30 ~14 min linux/x86_64 📦tgz
✖️ e837a48 #2 2023-11-17 17:06:41 ~30 min tests/e2e 📄log
✔️ e837a48 #2 2023-11-17 17:15:40 ~39 min windows/x86_64 💿exe
✔️ e837a48 #3 2023-11-17 18:00:23 ~32 min tests/e2e 📄log

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@igor-sirotin igor-sirotin merged commit 200c0b3 into master Nov 18, 2023
8 of 9 checks passed
@igor-sirotin igor-sirotin deleted the chore/remove-nim-unused-import branch November 18, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants