feat(@desktop/wallet): support alchemy sepolia api keys #12772
Conversation
Jenkins BuildsClick to see older builds (28)
|
Makefile
Outdated
| @@ -531,6 +531,10 @@ ifdef ALCHEMY_ETHEREUM_GOERLI_TOKEN | |||
| NIM_PARAMS += -d:ALCHEMY_ETHEREUM_GOERLI_TOKEN:"$(ALCHEMY_ETHEREUM_GOERLI_TOKEN)" | |||
| endif | |||
|
|
|||
| ifdef ALCHEMY_ETHEREUM_SEPOLIA_TOKEN | |||
There was a problem hiding this comment.
@dlipicar this seems to be unused, but still unremoved code, don't see any need for it since we switched to nim-confutils.
Please remove in a new commit within this PR code from the line 506 till the line 564.
Also if you could move OPENSEA_API_KEY to the new way of handling then you could remove that part from here as well.
There was a problem hiding this comment.
Opensea seems to be managed the new way already!
https://github.com/status-im/status-desktop/pull/12772/files#diff-e4c88de356005a46bf1fe7657caa45a87da077be8e702fac405ce08a70edcd1cR97
I'll just remove all of this then
There was a problem hiding this comment.
The one thing we don't seem to be doing in the new spot is inject the default values we have in the makefile
There was a problem hiding this comment.
Oh perhaps you meant the Tenor one? I'll move that to the new way
There was a problem hiding this comment.
@saledjenic see b08ed92
There was a problem hiding this comment.
Oh perhaps you meant the Tenor one? I'll move that to the new way
Exactly, that's what I meant to, but wrote open sea. :) Sorry.
There was a problem hiding this comment.
The one thing we don't seem to be doing in the new spot is inject the default values we have in the makefile
After merging this, for development purposes, developers should have at least build env vars set.
dlipicar
force-pushed
the
feat/alchemy-sepolia-support
branch
from
edffc6a
to
b08ed92
Compare
There was a problem hiding this comment.
@dlipicar these changes are good, just if the same tokens were used for the release builds we need to add them to CI.
dlipicar
force-pushed
the
feat/alchemy-sepolia-support
branch
4 times, most recently
from
14244c4
to
4944113
Compare
dlipicar
force-pushed
the
feat/alchemy-sepolia-support
branch
from
4944113
to
63eecaf
Compare
Closes #12771
What does the PR do
Enable support for Sepolia in the Alchemy client
Remove unused API-key related code from Makefile