chore(test): drop usage of ganache in old E2E tests #12759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anastasiyaig
approved these changes
Nov 16, 2023
Jenkins BuildsClick to see older builds (7)
|
stefandunca
approved these changes
Nov 16, 2023
| 'trufflesuite/ganache:v7.4.1' | ||
| ).run( | ||
| ["-p 127.0.0.1:${env.GANACHE_RPC_PORT}:8545", | ||
| "-v ${env.WORKSPACE}/test/ui-test/fixtures/ganache-dbs/goerli:/goerli-db"].join(' '), |
There was a problem hiding this comment.
@anastasiyaig, does the testing team plan to migrate the text fixture to the new tool, or should we also remove the ganache DB and data folder next?
There was a problem hiding this comment.
we want to try other solution, but ganache is dead completely so lets remove everything
jakubgs
force-pushed
the
ci/drop-ganache
branch
from
ed6c900
to
4658a99
Compare
The Ganache tool has been replaced by Hardhat: https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
ci/drop-ganache
branch
from
4658a99
to
f8d78cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ganache tool has been replaced by Hardhat:
https://consensys.io/blog/consensys-announces-the-sunset-of-truffle-and-ganache-and-new-hardhat
Also, yes, I don't use PR templates, call the police.