fix(ActivityCenter): Simplify and fix AC notifications read/unread states #12753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (7)
|
MishkaRogachev
force-pushed
the
fix/12619-mark-all-as-read-is-broken-in-the-activity-center
branch
from
397239e
to
12fc931
Compare
jrainville
reviewed
Nov 16, 2023
| @@ -54,36 +54,32 @@ proc init*(self: Controller) = | |||
| self.events.on(activity_center_service.SIGNAL_ACTIVITY_CENTER_NOTIFICATIONS_LOADED) do(e: Args): | |||
| let args = ActivityCenterNotificationsArgs(e) | |||
| self.delegate.addActivityCenterNotifications(args.activityCenterNotifications) | |||
| self.delegate.hasUnseenActivityCenterNotificationsChanged() | |||
There was a problem hiding this comment.
I think the module could call this signal on itself instead of the controller doing it.
There was a problem hiding this comment.
fixed (others also)
| if (evArgs.notificationIds.len > 0): | ||
| self.delegate.markActivityCenterNotificationReadDone(evArgs.notificationIds) | ||
| self.delegate.unreadActivityCenterNotificationsCountChanged() |
| if (evArgs.notificationIds.len > 0): | ||
| self.delegate.markActivityCenterNotificationUnreadDone(evArgs.notificationIds) | ||
| self.delegate.unreadActivityCenterNotificationsCountChanged() |
|
|
||
| self.events.on(activity_center_service.SIGNAL_ACTIVITY_CENTER_MARK_ALL_NOTIFICATIONS_AS_READ) do(e: Args): | ||
| self.delegate.markAllActivityCenterNotificationsReadDone() | ||
| self.delegate.unreadActivityCenterNotificationsCountChanged() |
MishkaRogachev
force-pushed
the
fix/12619-mark-all-as-read-is-broken-in-the-activity-center
branch
from
fabbcb8
to
7178455
Compare
MishkaRogachev
force-pushed
the
fix/12619-mark-all-as-read-is-broken-in-the-activity-center
branch
from
7178455
to
cd661be
Compare
jrainville
approved these changes
Nov 17, 2023
igor-sirotin
approved these changes
Nov 17, 2023
| self.events.emit(SIGNAL_ACTIVITY_CENTER_NOTIFICATIONS_COUNT_MAY_HAVE_CHANGED, Args()) | ||
| let notificationIds = @[notificationId] | ||
| discard backend.markActivityCenterNotificationsRead(notificationIds) | ||
| self.events.emit(SIGNAL_ACTIVITY_CENTER_MARK_NOTIFICATIONS_AS_READ, ActivityCenterNotificationIdsArgs(notificationIds: notificationIds)) |
There was a problem hiding this comment.
What exactly are the cases when we still need to emit SIGNAL_ACTIVITY_CENTER_NOTIFICATIONS_COUNT_MAY_HAVE_CHANGED? You removed it in a few places, but it's still there sometimes.
There was a problem hiding this comment.
There were extra calls, but its still needed
MishkaRogachev
deleted the
fix/12619-mark-all-as-read-is-broken-in-the-activity-center
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #12619
What does the PR do
Mark all readmarks ALL notifications as read (it's how it's implemented in status-go)Mark all readAffected areas
Activity center
Screenshot of functionality (including design for comparison)
Screen.Recording.2023-11-16.at.14.35.23.mov