fix: workaround to crash on startup with Qt 5.15.11 #12721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
requested review from
dlipicar,
jrainville,
micieslak and
Khushboo-dev-cpp
Jenkins BuildsClick to see older builds (8)
|
micieslak
reviewed
Nov 14, 2023
Khushboo-dev-cpp
approved these changes
Nov 14, 2023
caybro
force-pushed
the
fix/qt_15_5_11-crash-fix-aliased-property
branch
from
1cbed92
to
9831058
Compare
micieslak
approved these changes
Nov 14, 2023
the most recent Qt upstream version introduced a regression that causes our app to crash right on startup when a grouped property is assigned to inside a `PropertyChanges` handler upstream issue: https://bugreports.qt.io/browse/QTBUG-107795 Upstream fix will be released with Qt 5.15.12, code being at https://codereview.qt-project.org/c/qt/qtdeclarative/+/424702
caybro
force-pushed
the
fix/qt_15_5_11-crash-fix-aliased-property
branch
from
9831058
to
ee3a15c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the most recent Qt upstream version introduced a regression that causes our app to crash right on startup when a grouped property is assigned to inside a
PropertyChangeshandlerupstream issue: https://bugreports.qt.io/browse/QTBUG-107795
Upstream fix will be released with Qt 5.15.12, code being at https://codereview.qt-project.org/c/qt/qtdeclarative/+/424702
Culprit found thanks to
PagesValidatorfromstorybookWhat does the PR do
Fixes a nasty crash with Qt 5.15.11
Affected areas
ALL (indirectly via SendModal)
Screenshot of functionality (including design for comparison)
Back in business ;)
