Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TokensStore): Warnings cleanup #12714

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

noeliaSD
Copy link
Contributor

What does the PR do

TokensStore.qml - Warnings cleanup

@status-im-auto
Copy link
Member

status-im-auto commented Nov 13, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7ee5829 #1 2023-11-13 16:17:49 ~6 min tests/nim 📄log
✔️ 7ee5829 #1 2023-11-13 16:19:35 ~8 min macos/aarch64 🍎dmg
✔️ 7ee5829 #1 2023-11-13 16:21:57 ~10 min macos/x86_64 🍎dmg
✔️ 7ee5829 #1 2023-11-13 16:22:36 ~11 min tests/ui 📄log
✔️ 7ee5829 #1 2023-11-13 16:28:44 ~17 min linux/x86_64 📦tgz
✔️ 7ee5829 #1 2023-11-13 16:39:08 ~27 min windows/x86_64 💿exe
✖️ 7ee5829 #1 2023-11-13 16:46:43 ~35 min tests/e2e 📄log
✔️ 444f972 #2 2023-11-15 10:58:19 ~8 min tests/nim 📄log
✔️ 444f972 #2 2023-11-15 10:58:40 ~8 min macos/x86_64 🍎dmg
✔️ 444f972 #2 2023-11-15 11:02:29 ~12 min macos/aarch64 🍎dmg
✔️ 444f972 #2 2023-11-15 11:02:37 ~12 min tests/ui 📄log
✔️ 444f972 #2 2023-11-15 11:07:12 ~16 min linux/x86_64 📦tgz
✔️ 444f972 #2 2023-11-15 11:17:05 ~26 min windows/x86_64 💿exe
✖️ 444f972 #2 2023-11-15 11:19:32 ~29 min tests/e2e 📄log
✔️ 444f972 #4 2023-11-15 11:58:47 ~34 min tests/e2e 📄log

Copy link
Contributor

@endulab endulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

ui/app/AppLayouts/Wallet/stores/TokensStore.qml Outdated Show resolved Hide resolved
@glitchminer
Copy link
Contributor

Took a few minutes to load but was able to update without the app becoming unresponsive

@noeliaSD noeliaSD force-pushed the fix/cleanup-tokensstore-warnings branch from 7ee5829 to 444f972 Compare November 15, 2023 10:50
@noeliaSD noeliaSD marked this pull request as ready for review November 15, 2023 10:50
@noeliaSD
Copy link
Contributor Author

Rebased and ready to merge. This PR needs to be replicated for the 0.15.x branch.

@endulab endulab linked an issue Nov 15, 2023 that may be closed by this pull request
@noeliaSD noeliaSD merged commit 611598e into master Nov 15, 2023
8 of 9 checks passed
@noeliaSD noeliaSD deleted the fix/cleanup-tokensstore-warnings branch November 15, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update to 0.15 RC 1 using existing db
4 participants