feat(ActivityCenter): Fetch notifications on scroll to bottom #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (15)
|
|
@jrainville the ui is little bit laggy, i can make fetch function async for smoother UX |
jrainville
reviewed
Nov 13, 2023
MishkaRogachev
force-pushed
the
feat/activity-center-fetching-with-cursor
branch
from
5b498fd
to
4db2a2a
Compare
caybro
reviewed
Nov 14, 2023
MishkaRogachev
force-pushed
the
feat/activity-center-fetching-with-cursor
branch
from
4db2a2a
to
dc51178
Compare
jrainville
approved these changes
Nov 14, 2023
MishkaRogachev
force-pushed
the
feat/activity-center-fetching-with-cursor
branch
from
dc51178
to
0adab88
Compare
MishkaRogachev
force-pushed
the
feat/activity-center-fetching-with-cursor
branch
from
0adab88
to
967a901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9637
Partially fixes #12646
What does the PR do
Affected areas
Activity Center
Video of functionality
Screen.Recording.2023-11-13.at.18.38.31.mov
(on video limit of notifications is 7, default is 20)