feat(MintToken): Validation on name / symbol if exists in standard token list #12696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noeliaSD
requested review from
caybro,
micieslak,
alexandraB99,
alexjba and
Khushboo-dev-cpp
noeliaSD
force-pushed
the
feat/issue-12365
branch
from
177d2d0
to
7da6e6f
Compare
Jenkins BuildsClick to see older builds (5)
|
micieslak
reviewed
Nov 13, 2023
Comment on lines
71
to
88
| readonly property bool containsAssetReferenceName: root.isAssetView ? SQUtils.ModelUtils.contains(root.referenceAssetsBySymbolModel, "name", nameInput.text) : false | ||
| readonly property bool containsAssetReferenceSymbol: root.isAssetView ? SQUtils.ModelUtils.contains(root.referenceAssetsBySymbolModel, "symbol", symbolInput.text) : false | ||
|
|
There was a problem hiding this comment.
It could be done like that or via SFPM with two ValueFilter's inside AnyOf filter. Then it prevents from duplicates a bit better. ModelUtils.contains checks only in time of invocation, it won't be reevaluated when referenceAssetsBySymbolModel changes internally.
So let's say that user provides input, it's checked that's ok, but then in some community we know sb has created token with given name or symbol. This won't be detected in current approach and action of creating token with such duplicated name/symbol won't be blocked. On the other hand the the approach with SFPM is able to detect that so I would opt for using that approach here.
There was a problem hiding this comment.
Good point. Going to update it!
noeliaSD
force-pushed
the
feat/issue-12365
branch
from
7da6e6f
to
01987c4
Compare
…ken list - It adds link to the corresponding tokens model in `EditCommunityTokenView`. - It adds validation for `name` and `symbol`. - It updates `storybook accordingly.` Closes #12365
noeliaSD
force-pushed
the
feat/issue-12365
branch
from
01987c4
to
9ff83fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12365
What does the PR do
EditCommunityTokenView.nameandsymbol.storybook accordingly.NOTE: Real validation will be available into the app once the following pr is integrated
Affected areas
Community Settings / Mint Tokens
Screenshot of functionality
Screen.Recording.2023-11-10.at.16.37.31.mov