Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discord): Process delete channel & restart import button #12692

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

borismelnik
Copy link
Contributor

Fixes: #12684

What does the PR do

Process delete channel & restart import button

Affected areas

Discord import single channel

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?

@borismelnik
Copy link
Contributor Author

this PR waiting for STATUSGO, because there I fix Go auto replace string(request.CommunityID) to request.CommunityID.String() (unfortunately, its not the same)

@status-im-auto
Copy link
Member

status-im-auto commented Nov 10, 2023

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 122a403 #1 2023-11-10 13:33:20 ~6 min tests/nim 📄log
✔️ 122a403 #1 2023-11-10 13:36:18 ~9 min macos/aarch64 🍎dmg
✔️ 122a403 #1 2023-11-10 13:38:06 ~11 min tests/ui 📄log
✔️ 122a403 #1 2023-11-10 13:38:49 ~11 min macos/x86_64 🍎dmg
✔️ 122a403 #1 2023-11-10 13:42:03 ~15 min linux/x86_64 📦tgz
✔️ 122a403 #1 2023-11-10 14:03:09 ~36 min tests/e2e 📄log
✔️ 122a403 #1 2023-11-10 14:04:29 ~37 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 542ac0d #2 2023-11-13 10:40:01 ~5 min tests/nim 📄log
✔️ 542ac0d #2 2023-11-13 10:43:28 ~9 min macos/aarch64 🍎dmg
✔️ 542ac0d #2 2023-11-13 10:45:31 ~11 min tests/ui 📄log
✔️ 542ac0d #2 2023-11-13 10:47:23 ~12 min macos/x86_64 🍎dmg
✔️ 542ac0d #2 2023-11-13 10:47:54 ~13 min linux/x86_64 📦tgz
542ac0d #2 2023-11-13 10:57:54 ~23 min windows/x86_64 📄log
✔️ 542ac0d #2 2023-11-13 11:12:20 ~37 min tests/e2e 📄log
✔️ ae6cde7 #3 2023-11-14 09:09:15 ~5 min tests/nim 📄log
✔️ ae6cde7 #3 2023-11-14 09:12:44 ~9 min macos/x86_64 🍎dmg
✔️ ae6cde7 #3 2023-11-14 09:12:52 ~9 min macos/aarch64 🍎dmg
✔️ ae6cde7 #3 2023-11-14 09:14:18 ~10 min tests/ui 📄log
✔️ ae6cde7 #3 2023-11-14 09:19:06 ~15 min linux/x86_64 📦tgz
✔️ ae6cde7 #3 2023-11-14 09:34:31 ~30 min tests/e2e 📄log
✔️ ae6cde7 #3 2023-11-14 09:37:37 ~33 min windows/x86_64 💿exe

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You say it depends on status-go, but the vendor isn't updated 🤔

@borismelnik
Copy link
Contributor Author

LGTM. You say it depends on status-go, but the vendor isn't updated 🤔

yeah I don't want to point the same status-go commit to two different status-desktop PRs. :) I should merge this one first #12655 and when it will be merged this functionality should works correct :)

@borismelnik borismelnik force-pushed the fix/issue-12684-delete-channel-import branch from 122a403 to 542ac0d Compare November 13, 2023 10:34
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@borismelnik borismelnik force-pushed the fix/issue-12684-delete-channel-import branch from 542ac0d to ae6cde7 Compare November 14, 2023 09:03
@borismelnik borismelnik merged commit 69783e1 into master Nov 14, 2023
8 of 9 checks passed
@borismelnik borismelnik deleted the fix/issue-12684-delete-channel-import branch November 14, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord import channel: Delete channel & restart import button do nothing
4 participants