fix(@desktop/edit) : clicking up arrow opens edit view for a message … #12680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
kounkou
requested review from
igor-sirotin and
jrainville
and removed request for
jrainville and
igor-sirotin
kounkou
force-pushed
the
reply-to-message-with-image
branch
2 times, most recently
from
76f7ebd
to
730ab07
Compare
kounkou
force-pushed
the
reply-to-message-with-image
branch
from
730ab07
to
91d5e76
Compare
jrainville
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
This PR fixes #12019
This feature enables the user to edit the last message when clicking the Key_Up from the chat input. Based on the code base, this feature is triggered when the StatusChatInput receives events.
What we are trying to achieve is bring consistency between this Edit on Key_Up press in StatusChatInput and the Key_Right click from a mouse in order to trigger the Edit or the contextual menu that contains the Edit message.
Affected areas
Chat screen when clicking Up Key on keyboard
Screenshot of functionality (including design for comparison)