feat(@wallet/desktop): implement generalized collectibles api #12679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipicar
requested review from
alaibe,
IvanBelyakoff,
stefandunca,
saledjenic,
Cuteivist and
Khushboo-dev-cpp
Jenkins BuildsClick to see older builds (10)
|
dlipicar
commented
Nov 10, 2023
| else: | ||
| result.description = none(string) | ||
| let imageUrlNode = t{"image_url"} | ||
| if imageUrlNode != nil and imageUrlNode.kind != JNull: |
There was a problem hiding this comment.
I spent stupid amounts of time trying to make a generic Option unmarshaller like we have in Activity, but apparently for whatever reason Nim didn't handle recursively calling generic procs with different types, I ended up getting a runtime crash...
I can resume investigating it later, for now I just got tired...
dlipicar
force-pushed
the
feat/collectibles-api-generalization
branch
from
d9eba80
to
6c13cfa
Compare
IvanBelyakoff
approved these changes
Nov 14, 2023
dlipicar
force-pushed
the
feat/collectibles-api-generalization
branch
2 times, most recently
from
6e644dd
to
7c51434
Compare
dlipicar
force-pushed
the
feat/collectibles-api-generalization
branch
from
7c51434
to
3df3b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Part of #12578
Adjust client to the changes implemented in status-im/status-go#4290
Models are all the same, we're just adapting to the new functions / structs used in the backend.