chore(@desktop/wallet): Unifying the various "TokensTypes" across the app #12654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (40)
|
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
from
5ca7e3a
to
ab9764d
Compare
Khushboo-dev-cpp
force-pushed
the
chore/12424
branch
from
a36f1d7
to
98e3788
Compare
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
2 times, most recently
from
a1c641e
to
83cdcf8
Compare
Khushboo-dev-cpp
force-pushed
the
chore/12424
branch
from
98e3788
to
56ea0f9
Compare
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
from
83cdcf8
to
4f2fd95
Compare
Khushboo-dev-cpp
changed the title
Khushboo-dev-cpp
force-pushed
the
chore/12424
branch
2 times, most recently
from
dfb875d
to
36db2e7
Compare
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
from
4f2fd95
to
b73e352
Compare
Khushboo-dev-cpp
force-pushed
the
chore/12424
branch
8 times, most recently
from
8b287f6
to
58ce5e1
Compare
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
from
b73e352
to
ea79cfa
Compare
Cuteivist
approved these changes
Nov 20, 2023
stefandunca
approved these changes
Nov 20, 2023
| @@ -84,9 +84,10 @@ proc initShard*(cluster: int = -1, index: int = -1): Shard = | |||
| result.cluster = cluster | |||
| result.index = index | |||
|
|
|||
| # ToDo: Will be streamlined to single TokenType under https://github.com/status-im/status-desktop/pull/12654/files | |||
| type NewTokenType* {.pure.} = enum | |||
| type TokenType* {.pure.} = enum | |||
There was a problem hiding this comment.
I was thinking about how to avoid growing these catch-all types files. One way could be to follow the domain-driven design and not mix different topics (messaging with wallet). Does it make sense to have this into a blockchain_types.nim and the current types.nim into messaging_types.nim. Will this bring some clarity to the code for a newcomer?
There was a problem hiding this comment.
@stefandunca the reasoning for this is that eventually community tokens and wallet tokens are "tokens" and we are treating them even more so after the are listing the community tokens with account assets. hope that makes sense
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
from
ea79cfa
to
d6603b5
Compare
Khushboo-dev-cpp
force-pushed
the
fix/issue-12501
branch
from
d6603b5
to
d1837df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12501
What does the PR do
We found that TokenTypes was declared at multiple places in the app and this is an attempt to unify it into one
different versions found on nim side:
src/backend/activity.nim --> Used for activity as this was the only one that depended on backend for the values we kept those untouched
src/app_service/service/community/dto/community.nim --> used for community permission
New place:
src/app_service/common/types.nim
Affected areas
Community permissions, transaction activity , SendModal
StatusQ checklist
Screenshot of functionality (including design for comparison)