fix: activate community channel link #12653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (7)
|
MishkaRogachev
approved these changes
Nov 8, 2023
|
Just noted that it doesn't work for not yet spectated/joined communities. Fixing. |
igor-sirotin
force-pushed
the
fix/issue-12539-channel-links
branch
from
dfb1c53
to
0b1e419
Compare
|
@borismelnik @MishkaRogachev I've updated the PR, please check it out again 🙂 Now switching to a channel of non-spectated/joined community works as well. |
borismelnik
approved these changes
Nov 8, 2023
igor-sirotin
force-pushed
the
fix/issue-12539-channel-links
branch
from
0b1e419
to
67832f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12539
What does the PR do
chatIDfor chat lookup, as it should be a concatenation of community id and channel idactivateStatusDeepLink. Channel should be processed earlier, because communityId is also setchannelUuidfieldswitchTofunctionScreenshot of functionality (including design for comparison)
Screen.Recording.2023-11-08.at.11.51.32.mov