Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet) Wallet Connect pair implementation #12604

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Nov 1, 2023

Closes #12551

status-go PR #4240

Forwards Wallet Connect SDK to status-go and the other way around for implementation events

Notes:

  • Environment variable STATUS_BUILD_WALLET_CONNECT_PROJECT_ID must be defined at compile time
    • Not yet added to CI or code
  • Implements WalletConnect SDK tester integrated with status-go for quick prototyping

Integration demo using https://react-app.walletconnect.com/

WC_pair.mov

@status-im-auto
Copy link
Member

status-im-auto commented Nov 1, 2023

Jenkins Builds

Click to see older builds (41)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ dfa2a42 #1 2023-11-01 14:39:22 ~2 min tests/e2e 📄log
✔️ 7ef08b2 #2 2023-11-01 16:42:22 ~5 min tests/nim 📄log
✔️ 7ef08b2 #2 2023-11-01 16:42:43 ~5 min macos/aarch64 🍎dmg
✔️ 7ef08b2 #2 2023-11-01 16:46:15 ~9 min tests/ui 📄log
✔️ 7ef08b2 #2 2023-11-01 16:46:29 ~9 min macos/x86_64 🍎dmg
✔️ 7ef08b2 #2 2023-11-01 16:52:30 ~15 min linux/x86_64 📦tgz
✖️ 7ef08b2 #2 2023-11-01 17:07:01 ~30 min tests/e2e 📄log
✔️ 7ef08b2 #2 2023-11-01 17:07:37 ~30 min windows/x86_64 💿exe
✔️ c924c08 #3 2023-11-03 16:13:46 ~5 min macos/aarch64 🍎dmg
✔️ c924c08 #3 2023-11-03 16:17:17 ~8 min macos/x86_64 🍎dmg
✔️ c924c08 #3 2023-11-03 16:17:37 ~9 min tests/nim 📄log
✔️ c924c08 #3 2023-11-03 16:25:00 ~16 min tests/ui 📄log
✔️ c924c08 #3 2023-11-03 16:25:23 ~17 min linux/x86_64 📦tgz
✔️ c924c08 #3 2023-11-03 16:37:14 ~28 min windows/x86_64 💿exe
✔️ c924c08 #3 2023-11-03 16:45:55 ~37 min tests/e2e 📄log
✔️ 5217b8a #4 2023-11-03 17:11:26 ~5 min tests/nim 📄log
✔️ 5217b8a #4 2023-11-03 17:13:00 ~7 min macos/x86_64 🍎dmg
✔️ 5217b8a #4 2023-11-03 17:15:04 ~9 min macos/aarch64 🍎dmg
✔️ 5217b8a #4 2023-11-03 17:17:30 ~12 min tests/ui 📄log
✔️ 5217b8a #4 2023-11-03 17:20:13 ~14 min linux/x86_64 📦tgz
✔️ 5217b8a #4 2023-11-03 17:29:43 ~24 min windows/x86_64 💿exe
✖️ 5217b8a #4 2023-11-03 17:37:32 ~32 min tests/e2e 📄log
✔️ 52666aa #5 2023-11-06 10:15:23 ~5 min tests/nim 📄log
✔️ 52666aa #5 2023-11-06 10:15:26 ~5 min macos/aarch64 🍎dmg
✔️ 52666aa #5 2023-11-06 10:21:07 ~11 min macos/x86_64 🍎dmg
✔️ 52666aa #5 2023-11-06 10:21:14 ~11 min tests/ui 📄log
✔️ 02574c1 #6 2023-11-06 10:28:23 ~4 min macos/aarch64 🍎dmg
✔️ 8d5a201 #7 2023-11-06 10:33:50 ~4 min macos/aarch64 🍎dmg
✔️ 8d5a201 #7 2023-11-06 10:34:14 ~5 min tests/nim 📄log
✔️ 8d5a201 #7 2023-11-06 10:39:22 ~10 min macos/x86_64 🍎dmg
✔️ 8d5a201 #7 2023-11-06 10:39:32 ~10 min tests/ui 📄log
✔️ 8d5a201 #7 2023-11-06 10:43:05 ~14 min linux/x86_64 📦tgz
✔️ 8d5a201 #7 2023-11-06 10:56:22 ~27 min windows/x86_64 💿exe
✔️ 8d5a201 #7 2023-11-06 10:58:29 ~29 min tests/e2e 📄log
✔️ dda15da #8 2023-11-08 11:02:35 ~5 min tests/nim 📄log
✔️ dda15da #8 2023-11-08 11:04:40 ~7 min macos/aarch64 🍎dmg
✔️ dda15da #8 2023-11-08 11:05:38 ~8 min macos/x86_64 🍎dmg
✔️ dda15da #8 2023-11-08 11:08:30 ~11 min tests/ui 📄log
✔️ dda15da #8 2023-11-08 11:10:32 ~13 min linux/x86_64 📦tgz
✖️ dda15da #8 2023-11-08 11:22:48 ~26 min tests/e2e 📄log
✔️ dda15da #8 2023-11-08 11:27:30 ~30 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 59e4773 #9 2023-11-14 18:24:16 ~6 min tests/nim 📄log
✔️ 59e4773 #9 2023-11-14 18:27:11 ~9 min macos/x86_64 🍎dmg
✔️ 59e4773 #9 2023-11-14 18:27:15 ~9 min macos/aarch64 🍎dmg
✔️ 59e4773 #9 2023-11-14 18:29:15 ~11 min tests/ui 📄log
✔️ 59e4773 #9 2023-11-14 18:31:29 ~13 min linux/x86_64 📦tgz
✖️ 59e4773 #9 2023-11-14 18:48:10 ~30 min tests/e2e 📄log
✔️ 59e4773 #9 2023-11-14 18:48:11 ~30 min windows/x86_64 💿exe
✔️ 2e472c5 #10 2023-11-15 14:00:00 ~5 min macos/aarch64 🍎dmg
✔️ 2e472c5 #10 2023-11-15 14:00:07 ~5 min tests/nim 📄log
✔️ 2e472c5 #10 2023-11-15 14:03:01 ~8 min macos/x86_64 🍎dmg
✔️ 2e472c5 #10 2023-11-15 14:08:01 ~13 min tests/ui 📄log
✔️ 2e472c5 #10 2023-11-15 14:08:49 ~14 min linux/x86_64 📦tgz
✔️ 2e472c5 #10 2023-11-15 14:24:35 ~30 min windows/x86_64 💿exe
✔️ 2e472c5 #10 2023-11-15 14:25:20 ~31 min tests/e2e 📄log

@stefandunca stefandunca changed the title feat(wallet) Wallet Connect session proposal implementation feat(wallet) Wallet Connect pair implementation Nov 1, 2023
@stefandunca stefandunca force-pushed the wc_pair_api-12551 branch 6 times, most recently from 02574c1 to 8d5a201 Compare November 6, 2023 10:28
@stefandunca stefandunca marked this pull request as ready for review November 6, 2023 10:28
Copy link
Contributor

@dlipicar dlipicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Add GO helper to:
- loads WalletConnect SDK bundle
- bootstraps status-go user session
- provides a way to call status-go API from webview
- forwards status-go signals to webview

Updates: #12551
Implement Controller to forward requests between status-go and SDK
implementation in QML.

Other changes:

- Source Wallet Connect projectId from env vars
- Mock controller in storybook

Updates #12551
@stefandunca stefandunca merged commit bcf5b64 into master Nov 15, 2023
8 of 9 checks passed
@stefandunca stefandunca deleted the wc_pair_api-12551 branch November 15, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement WalletConnect Pair API (stub UI)
4 participants