-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet) Wallet Connect pair implementation #12604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (41)
|
stefandunca
changed the title
feat(wallet) Wallet Connect session proposal implementation
feat(wallet) Wallet Connect pair implementation
Nov 1, 2023
stefandunca
force-pushed
the
wc_pair_api-12551
branch
6 times, most recently
from
November 6, 2023 10:28
02574c1
to
8d5a201
Compare
stefandunca
requested review from
alaibe,
dlipicar,
IvanBelyakoff and
saledjenic
November 6, 2023 10:29
stefandunca
force-pushed
the
wc_pair_api-12551
branch
from
November 8, 2023 10:56
8d5a201
to
dda15da
Compare
dlipicar
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
stefandunca
force-pushed
the
wc_pair_api-12551
branch
from
November 14, 2023 18:17
dda15da
to
59e4773
Compare
1 task
saledjenic
approved these changes
Nov 15, 2023
Add GO helper to: - loads WalletConnect SDK bundle - bootstraps status-go user session - provides a way to call status-go API from webview - forwards status-go signals to webview Updates: #12551
Implement Controller to forward requests between status-go and SDK implementation in QML. Other changes: - Source Wallet Connect projectId from env vars - Mock controller in storybook Updates #12551
stefandunca
force-pushed
the
wc_pair_api-12551
branch
from
November 15, 2023 13:53
59e4773
to
2e472c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12551
status-go
PR #4240Forwards Wallet Connect SDK to status-go and the other way around for implementation events
Notes:
STATUS_BUILD_WALLET_CONNECT_PROJECT_ID
must be defined at compile timestatus-go
for quick prototypingIntegration demo using https://react-app.walletconnect.com/
WC_pair.mov