-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(@desktop/wallet): Fix new transaction button visuals #12589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (15)
|
caybro
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one minor thing
Cuteivist
force-pushed
the
bug/12567-new-transaction-button
branch
from
October 31, 2023 11:59
9ed1509
to
ec9db47
Compare
stefandunca
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏼
Khushboo-dev-cpp
approved these changes
Nov 1, 2023
Cuteivist
force-pushed
the
bug/12567-new-transaction-button
branch
from
November 3, 2023 12:10
ec9db47
to
717cb08
Compare
* Fixed duplicated wallet activity fetch request * Fixed not resetting tab on wallet account add
Cuteivist
force-pushed
the
bug/12567-new-transaction-button
branch
from
November 9, 2023 10:28
717cb08
to
5f7a656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12567
What does the PR do
Activity is refreshed automatically in case list is empty and filter is not applied.
When filter is applied the "clear button" is hidden and new transactions button is showed.
Other fixes:
assets
after account is addedAffected areas
Wallet activity
Screenshot of functionality (including design for comparison)
2023-10-31_10-53-26.mp4