Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(@desktop/wallet): Fix new transaction button visuals #12589

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Cuteivist
Copy link
Contributor

fixes #12567

What does the PR do

  • Fixed new transactions button display
    Activity is refreshed automatically in case list is empty and filter is not applied.
    When filter is applied the "clear button" is hidden and new transactions button is showed.

Other fixes:

  • Fixed duplicated wallet activity fetch request
  • Fixed wallet view tab was not resetting to assets after account is added

Affected areas

Wallet activity

Screenshot of functionality (including design for comparison)

2023-10-31_10-53-26.mp4

@status-im-auto
Copy link
Member

status-im-auto commented Oct 31, 2023

Jenkins Builds

Click to see older builds (15)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9ed1509 #1 2023-10-31 10:19:18 ~5 min tests/nim 📄log
✔️ 9ed1509 #1 2023-10-31 10:21:43 ~8 min macos/aarch64 🍎dmg
✔️ 9ed1509 #1 2023-10-31 10:24:00 ~10 min macos/x86_64 🍎dmg
9ed1509 #1 2023-10-31 10:25:26 ~12 min tests/ui 📄log
✔️ 9ed1509 #1 2023-10-31 10:28:30 ~15 min linux/x86_64 📦tgz
✔️ 9ed1509 #1 2023-10-31 10:43:43 ~30 min windows/x86_64 💿exe
✔️ 9ed1509 #1 2023-10-31 10:48:18 ~35 min tests/e2e 📄log
✔️ ec9db47 #2 2023-10-31 12:05:37 ~5 min macos/aarch64 🍎dmg
✔️ ec9db47 #2 2023-10-31 12:06:34 ~6 min tests/nim 📄log
✔️ ec9db47 #2 2023-10-31 12:10:46 ~10 min macos/x86_64 🍎dmg
✔️ ec9db47 #2 2023-10-31 12:11:37 ~11 min tests/ui 📄log
✔️ ec9db47 #2 2023-10-31 12:16:02 ~16 min linux/x86_64 📦tgz
✔️ ec9db47 #2 2023-10-31 12:24:01 ~23 min windows/x86_64 💿exe
✖️ ec9db47 #2 2023-10-31 12:35:47 ~35 min tests/e2e 📄log
✖️ ec9db47 #3 2023-11-01 05:05:18 ~5 min tests/e2e 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 717cb08 #3 2023-11-03 12:19:11 ~7 min macos/aarch64 🍎dmg
✔️ 717cb08 #3 2023-11-03 12:22:56 ~11 min macos/x86_64 🍎dmg
✔️ 717cb08 #3 2023-11-03 12:24:54 ~13 min tests/nim 📄log
✔️ 717cb08 #3 2023-11-03 12:29:26 ~18 min linux/x86_64 📦tgz
✔️ 717cb08 #3 2023-11-03 12:31:45 ~20 min tests/ui 📄log
✖️ 717cb08 #5 2023-11-03 12:36:31 ~25 min tests/e2e 📄log
✔️ 717cb08 #3 2023-11-03 12:39:37 ~28 min windows/x86_64 💿exe
✖️ 717cb08 #6 2023-11-03 14:34:18 ~5 min tests/e2e 📄log
✖️ 717cb08 #7 2023-11-03 15:13:13 ~34 min tests/e2e 📄log
✖️ 717cb08 #8 2023-11-03 17:37:59 ~18 min tests/e2e 📄log
✔️ 5f7a656 #4 2023-11-09 10:34:52 ~6 min tests/nim 📄log
✔️ 5f7a656 #4 2023-11-09 10:37:09 ~8 min macos/aarch64 🍎dmg
✔️ 5f7a656 #4 2023-11-09 10:37:29 ~8 min macos/x86_64 🍎dmg
✔️ 5f7a656 #4 2023-11-09 10:39:43 ~10 min tests/ui 📄log
✔️ 5f7a656 #4 2023-11-09 10:43:37 ~14 min linux/x86_64 📦tgz
✔️ 5f7a656 #4 2023-11-09 10:51:35 ~22 min windows/x86_64 💿exe
✔️ 5f7a656 #9 2023-11-09 11:04:10 ~35 min tests/e2e 📄log

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just one minor thing

ui/app/AppLayouts/Wallet/stores/ActivityFiltersStore.qml Outdated Show resolved Hide resolved
@Cuteivist Cuteivist force-pushed the bug/12567-new-transaction-button branch from 9ed1509 to ec9db47 Compare October 31, 2023 11:59
Copy link
Contributor

@stefandunca stefandunca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@Cuteivist Cuteivist force-pushed the bug/12567-new-transaction-button branch from ec9db47 to 717cb08 Compare November 3, 2023 12:10
* Fixed duplicated wallet activity fetch request
* Fixed not resetting tab on wallet account add
@Cuteivist Cuteivist force-pushed the bug/12567-new-transaction-button branch from 717cb08 to 5f7a656 Compare November 9, 2023 10:28
@Cuteivist Cuteivist merged commit 90cfc08 into master Nov 14, 2023
8 of 9 checks passed
@Cuteivist Cuteivist deleted the bug/12567-new-transaction-button branch November 14, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet activity 'New transaction' button is placed incorrectly
5 participants