feat: info msg if owner is not awailable after community ownership change #12560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprakhov
requested review from
a team,
iurimatias,
shinnok,
jrainville,
osmaczko and
endulab
and removed request for
a team
Jenkins BuildsClick to see older builds (15)
|
mprakhov
force-pushed
the
mp/issue-11969
branch
from
dd57cb9
to
16f374a
Compare
mprakhov
force-pushed
the
mp/issue-11969
branch
from
16f374a
to
23afd6f
Compare
jrainville
reviewed
Oct 27, 2023
ui/app/AppLayouts/Communities/panels/ControlNodeOfflineCenterPanel.qml
Outdated
Show resolved
Hide resolved
ui/app/AppLayouts/Communities/views/ControlNodeOfflineCommunityView.qml
Outdated
Show resolved
Hide resolved
mprakhov
force-pushed
the
mp/issue-11969
branch
2 times, most recently
from
7797745
to
b579e1c
Compare
jrainville
approved these changes
Oct 31, 2023
mprakhov
force-pushed
the
mp/issue-11969
branch
from
b579e1c
to
8d89f10
Compare
mprakhov
force-pushed
the
mp/issue-11969
branch
from
8d89f10
to
75d1649
Compare
osmaczko
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
When the community ownership changes, the new owner will kick out all members and they must reveal their address in order to rejoin the community. As soon, as they will do it - they will automatically rejoin by the control node.
If the control node will not be online to accept them, the appropriate info msg will be displayed
Closes: #11969
status-go PR: status-im/status-go#4187
Affected areas
Ownership change
Screenshot of functionality (including design for comparison)
Screen.Recording.2023-10-26.at.22.21.34.mov