fix ImportCommunityPopup issues, remove private key importing
#12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
caybro,
jrainville,
alexandraB99 and
anastasiyaig
Jenkins BuildsClick to see older builds (7)
|
jrainville
approved these changes
Oct 26, 2023
igor-sirotin
force-pushed
the
fix/issue-12542-import-community-popup
branch
from
76f6596
to
c47dc02
Compare
caybro
reviewed
Oct 26, 2023
| return Utils.getCommunityDataFromSharedLink(inputKey).communityId; | ||
| if (Utils.isStatusDeepLink(inputKey)) { | ||
| const linkData = Utils.getCommunityDataFromSharedLink(inputKey) | ||
| return !linkData ? "" : linkData.communityId |
There was a problem hiding this comment.
Suggested change
| return !linkData ? "" : linkData.communityId | |
| return !!linkData ? linkData.communityId : "" |
I always find this double negative idiom ugly :)
There was a problem hiding this comment.
I don't get it, you find it ugly, but still suggest? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12465
Fixes #12542
Drops the usage of
parseCommunitySharedUrl(#12356)What does the PR do
requestCommunityInfocallreuestCommunityInfofromgetCommunityDetails.Because the former returns nothing and requires binding to nim signals.
ImportCommunityPopupAffected areas
ImportCommunityPopup
Screenshot of functionality (including design for comparison)
Screen.Recording.2023-10-26.at.11.02.21.mov
Screen.Recording.2023-10-26.at.11.05.15.mov