You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors functionality of minting, airdrop and burn regarding handling fees. Provided earlier utilities AmountsArithmetic are used to handle amounts as big integers instead of floats. It prevents from problems described in #11376. Permissions functionality will be covered in a separate task.
There are other places which imho need some fixes (like WalletAccountsModel in storybook)?
The functionality I've refactored doesn't use wallte model's assets, where amounts are expressed as floats. That should be changed in the next iteration when functionality using that will be altered.
Hey @micieslak , not entirely sure if this is covered by these changes but there was a discrepancy noted when viewing remaining tokens and attempting to airdrop.
Create token with 999,999,999 supply and 10 decimal places
Airdrop 0.000000001
Remaining supply still shows 999,999,999
Start another airdrop - 999,999,999 is accepted without error despite the available balance being only 999999998.999999999
Also note that despite being configured with 10 decimal places the number that is able to be used while airdropping depends on the size of integer
Hey @micieslak , not entirely sure if this is covered by these changes but there was a discrepancy noted when viewing remaining tokens and attempting to airdrop.
Thanks @glitchminer for pointing those issues. The same problem exists in the current master and they are not directly related to this PR so I created separate tasks for them:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
micieslak
requested review from
caybro,
alexandraB99,
alexjba,
endulab and
noeliaSD
What does the PR do
This PR refactors functionality of minting, airdrop and burn regarding handling fees. Provided earlier utilities
AmountsArithmeticare used to handle amounts as big integers instead of floats. It prevents from problems described in #11376. Permissions functionality will be covered in a separate task.Closes: #11491
Permissions part is going to be covered in a separate task: #11863
Affected areas
Multiple components for community settings,
AmountsArithmetic