Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate account name and keypairs that are under 5 characters #13384

Closed
benjthayer opened this issue Feb 1, 2024 · 1 comment · Fixed by #13414
Closed

Validate account name and keypairs that are under 5 characters #13384

benjthayer opened this issue Feb 1, 2024 · 1 comment · Fixed by #13414

Comments

@benjthayer
Copy link

benjthayer commented Feb 1, 2024

New validation states have been added to the various flows listed below to prevent the user from entering an account or keypair name that is <5 characters. This change was requested originally by @saledjenic and has been completed as part of a sweep of backlog items.

Flows where this validation is now featured:

1. Editing an existing account

Screenshot 2024-02-01 at 4 34 17 PM

Figma:
https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21039-220481&mode=design&t=2O68lxNGG9g1b1tx-4

--

2. Rename keypair (Wallet Settings)

Screenshot 2024-02-01 at 4 28 20 PM

Figma:
https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=23264-284147&mode=design&t=i8YMYAMFRqAFgJ3v-4

--

3. Add new keypair via seed phrase

Screenshot 2024-02-01 at 4 27 22 PM

Figma:
https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21240-102220&mode=design&t=2O68lxNGG9g1b1tx-4

--

4. Add new account via private key

Screenshot 2024-02-01 at 4 30 47 PM

Figma:
https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=21240-102386&mode=design&t=2O68lxNGG9g1b1tx-4

--

  1. Generate new keypair - naming the new keypair
    (Validation same as others and not shown again in design as would be duplicative)
@lukaszso
Copy link

I've edited our existing test cases to include the minimum character limits:

  1. Editing an existing account
  2. Rename keypair (Wallet Settings)
  3. Add new keypair via seed phrase
  4. Add new account via private key
  5. Generate new keypair - naming the new keypair

And here is a completed test run for this ticket: TestRail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment