Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet settings: Change of RPC URLs requires app restart #13380

Closed
benjthayer opened this issue Feb 1, 2024 · 2 comments · Fixed by #13512
Closed

Wallet settings: Change of RPC URLs requires app restart #13380

benjthayer opened this issue Feb 1, 2024 · 2 comments · Fixed by #13512

Comments

@benjthayer
Copy link

benjthayer commented Feb 1, 2024

In order to implement changes to network RPC URLs in Wallet Settings, the user must restart the app after making their changes.

The designs have been updated in a couple of ways to promote this requirement and also to prompt the user to restart the app when attempting to save changes to Network settings which include any change to RPC URLs.

Itemised changes to flow:

  1. Both RPC URLs (Main and Failover) have updated info text:
    Required (changes require restart) and Optional (changes require restart):
Screenshot 2024-02-01 at 2 32 58 PM

--

  1. When the user clicks Save changes, if there are any changes to RPC URLs (either Main or Failover or both), they are shown a dialog which enables them to restart in order for the changes to take effect or save the changes for later.
Wallet

--

  1. If the user selects Save and restart later, the RPC URL changes will be implemented the next time they restart the app. The information text under the RPC URL field confirms this:
Screenshot 2024-02-01 at 2 40 33 PM

--

These changes have been implemented to ensure the user is able to change multiple RPC URLs across multiple networks before having to restart.

Figma:
https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=23255-189132&mode=design&t=0DRwQJKDGYJPHkq1-4

@alaibe
Copy link
Collaborator

alaibe commented Feb 5, 2024

What is missing is the part that shows "restart required for changes to take effect"

@alaibe alaibe added this to the 2.28.0 Beta milestone Feb 5, 2024
@alaibe alaibe self-assigned this Feb 5, 2024
@caybro
Copy link
Member

caybro commented Feb 5, 2024

What is missing is the part that shows "restart required for changes to take effect"

In LanguageView.qml, we have sth very similar:

        Loader {
            id: languageConfirmationDialog
            active: false
            sourceComponent: ConfirmationDialog {
                headerSettings.title: qsTr("Change language")
                confirmationText: qsTr("Display language has been changed. You must restart the application for changes to take effect.")
                confirmButtonLabel: qsTr("Close the app now")
                onConfirmButtonClicked: {
                    languageConfirmationDialog.active = false
                    Qt.quit()
                }
            }
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment