Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat: remove outdated integration for ChatCommandModal #12118

Closed
Tracked by #11376
micieslak opened this issue Sep 11, 2023 · 0 comments · Fixed by #12119
Closed
Tracked by #11376

Chat: remove outdated integration for ChatCommandModal #12118

micieslak opened this issue Sep 11, 2023 · 0 comments · Fixed by #12119
Assignees
@micieslak
Labels
chore
Milestone
0.15

Comments

@micieslak
Copy link
Member

Description

Functionality of sending/receiving funds directly from the chat is outdated both in code (which is unreachable and unmaintained) and designs: https://www.figma.com/file/Mr3rqxxgKJ2zMQ06UAKiWL/%F0%9F%92%AC-Chat%E2%8E%9CDesktop?type=design&node-id=1335-145&mode=design&t=2k8OmchnCFOe6IRQ-0.
Any further maintenance of that code makes no sense while it's impossible to test. Because of that the old glue code should be removed, but the components itself will be left for potential future use.

Related to: #11376
@micieslak micieslak self-assigned this Sep 11, 2023
micieslak added a commit that referenced this issue Sep 11, 2023
@micieslak
StatusChatInput: remove unmaintained integration with ChatCommandsPopup
a67ff17 
The functionality for sending/receiving funds directly from chat
is currently not supported, both code and designs are outdated.
This commit removes integration part but leaves ChatCommandsPopup
component for potential future use.

Closes: #12118
@micieslak micieslak mentioned this issue Sep 11, 2023
Merged
micieslak added a commit that referenced this issue Sep 11, 2023
@micieslak
StatusChatInput: remove unmaintained integration with ChatCommandsPopup
f8347af 
The functionality for sending/receiving funds directly from chat
is currently not supported, both code and designs are outdated.
This commit removes integration part but leaves ChatCommandsPopup
component for potential future use.

Closes: #12118
@alexandraB99 alexandraB99 added this to the 0.15 milestone Sep 11, 2023
@alexandraB99 alexandraB99 mentioned this issue Sep 12, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micieslak micieslak

Labels
chore
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

StatusChatInput: remove unmaintained integration with ChatCommandsPopup status-im/status-desktop
2 participants
@micieslak @alexandraB99