Skip to content

Commit

Permalink
Revert "feat: shards.test fleet"
Browse files Browse the repository at this point in the history
This reverts commit 1eeefc4.
  • Loading branch information
jrainville committed Nov 17, 2023
1 parent 4d1fd3a commit a33ff4d
Show file tree
Hide file tree
Showing 11 changed files with 55 additions and 136 deletions.
120 changes: 46 additions & 74 deletions fleets.json

Large diffs are not rendered by default.

27 changes: 3 additions & 24 deletions src/app/core/fleets/fleet_configuration.nim
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,13 @@ type
GoWakuTest = "go-waku.test"
StatusTest = "status.test"
StatusProd = "status.prod"
ShardsTest = "shards.test"

FleetNodes* {.pure.} = enum
Bootnodes = "boot",
Mailservers = "mail",
Rendezvous = "rendezvous",
Whisper = "whisper",
Waku = "tcp/p2p/waku"
WakuENR = "enr/p2p/waku"
WakuBoot = "tcp/p2p/waku/boot"
WakuBootENR = "enr/p2p/waku/boot"
WakuStore = "tcp/p2p/waku/store"
Websocket = "wss/p2p/waku"

Meta* = object
Expand Down Expand Up @@ -59,30 +54,14 @@ proc extractConfig(self: FleetConfiguration, jsonString: string) {.gcsafe.} =
self.fleet[fleet][nodes][server] = fleetJson["fleets"][fleet][nodes][server].getStr

proc getNodes*(self: FleetConfiguration, fleet: Fleet, nodeType: FleetNodes = FleetNodes.Bootnodes): seq[string] =
var t = nodeType
if fleet == Fleet.ShardsTest:
case nodeType:
of Bootnodes: t = WakuBoot
of Mailservers: t = WakuStore
of WakuENR: t = WakuBootENR
else: discard

if not self.fleet[$fleet].hasKey($t): return
result = toSeq(self.fleet[$fleet][$t].values)
if not self.fleet[$fleet].hasKey($nodeType): return
result = toSeq(self.fleet[$fleet][$nodeType].values)

proc getMailservers*(self: FleetConfiguration, fleet: Fleet, isWakuV2: bool): Table[string, string] =
# TODO: If using wakuV2, this assumes that Waku nodes in fleet.status.json are also store nodes.
# Maybe it make senses to add a "waku-store" section in case we want to have separate node types?
# Discuss with @iurimatias, @cammellos and Vac team
var fleetKey: string
if isWakuV2:
if fleet == Fleet.ShardsTest:
fleetKey = $FleetNodes.WakuStore
else:
fleetKey = $FleetNodes.Waku
else:
fleetKey = $FleetNodes.Mailservers

let fleetKey = if isWakuV2: $FleetNodes.Waku else: $FleetNodes.Mailservers
if not self.fleet[$fleet].hasKey(fleetKey) :
result = initTable[string,string]()
return
Expand Down
10 changes: 3 additions & 7 deletions src/app_service/service/accounts/service.nim
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ QtObject:

proc getDefaultNodeConfig*(self: Service, installationId: string, recoverAccount: bool): JsonNode =
let fleet = Fleet.StatusProd
let dnsDiscoveryURL = "enrtree://AL65EKLJAUXKKPG43HVTML5EFFWEZ7L4LOKTLZCLJASG4DSESQZEC@prod.status.nodes.status.im"
let dnsDiscoveryURL = @["enrtree://AL65EKLJAUXKKPG43HVTML5EFFWEZ7L4LOKTLZCLJASG4DSESQZEC@prod.status.nodes.status.im"]

result = NODE_CONFIG.copy()
result["ClusterConfig"]["Fleet"] = newJString($fleet)
Expand All @@ -326,12 +326,8 @@ QtObject:

# TODO: fleet.status.im should have different sections depending on the node type
# or maybe it's not necessary because a node has the identify protocol
result["ClusterConfig"]["WakuNodes"] = %* @[dnsDiscoveryURL]

var discV5Bootnodes = self.fleetConfiguration.getNodes(fleet, FleetNodes.WakuENR)
discV5Bootnodes.add(dnsDiscoveryURL)

result["ClusterConfig"]["DiscV5BootstrapNodes"] = %* discV5Bootnodes
result["ClusterConfig"]["WakuNodes"] = %* dnsDiscoveryURL
result["ClusterConfig"]["DiscV5BootstrapNodes"] = %* dnsDiscoveryURL

if TEST_PEER_ENR != "":
let testPeerENRArr = %* @[TEST_PEER_ENR]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ type
StoreCapacity*: int
StoreSeconds*: int
EnableFilterFullNode*: bool
UseShardAsDefaultTopic*: bool

ShhextConfig* = object
PFSEnabled*: bool
Expand Down Expand Up @@ -331,7 +330,6 @@ proc toWaku2Config*(jsonObj: JsonNode): Waku2Config =
discard jsonObj.getProp("StoreCapacity", result.StoreCapacity)
discard jsonObj.getProp("StoreSeconds", result.StoreSeconds)
discard jsonObj.getProp("EnableFilterFullNode", result.EnableFilterFullNode)
discard jsonObj.getProp("UseShardAsDefaultTopic", result.UseShardAsDefaultTopic)

proc toWakuConfig*(jsonObj: JsonNode): WakuConfig =
discard jsonObj.getProp("Enabled", result.Enabled)
Expand Down
14 changes: 1 addition & 13 deletions src/app_service/service/node_configuration/service.nim
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,6 @@ proc getBloomLevel*(self: Service): string =
else:
return BLOOM_LEVEL_LIGHT

proc isShardFleet(config: NodeConfigDto): bool =
return case config.ClusterConfig.Fleet:
of $Fleet.ShardsTest: true
else: false

proc setWakuConfig(configuration: NodeConfigDto, wakuVersion: int): NodeConfigDto =
var newConfiguration = configuration
Expand All @@ -133,7 +129,6 @@ proc setWakuConfig(configuration: NodeConfigDto, wakuVersion: int): NodeConfigDt
newConfiguration.WakuV2Config.EnableDiscV5 = true
newConfiguration.WakuV2Config.DiscoveryLimit = 20
newConfiguration.WakuV2Config.Rendezvous = true
newConfiguration.WakuV2Config.UseShardAsDefaultTopic = isShardFleet(newConfiguration)

return newConfiguration

Expand Down Expand Up @@ -235,18 +230,11 @@ proc setFleet*(self: Service, fleet: string): bool =
dnsDiscoveryURL.add("enrtree://AIO6LUM3IVWCU2KCPBBI6FEH2W42IGK3ASCZHZGG5TIXUR56OGQUO@test.status.nodes.status.im")
of Fleet.StatusProd:
dnsDiscoveryURL.add("enrtree://AL65EKLJAUXKKPG43HVTML5EFFWEZ7L4LOKTLZCLJASG4DSESQZEC@prod.status.nodes.status.im")
of Fleet.ShardsTest:
dnsDiscoveryURL.add("enrtree://AMOJVZX4V6EXP7NTJPMAYJYST2QP6AJXYW76IU6VGJS7UVSNDYZG4@boot.test.shards.nodes.status.im")
else:
wakuVersion = 1

newConfiguration.ClusterConfig.WakuNodes = dnsDiscoveryURL

var discV5Bootnodes = self.fleetConfiguration.getNodes(fleetType, FleetNodes.WakuENR)
if dnsDiscoveryURL.len != 0:
discV5Bootnodes.add(dnsDiscoveryURL[0])

newConfiguration.ClusterConfig.DiscV5BootstrapNodes = discV5Bootnodes
newConfiguration.ClusterConfig.DiscV5BootstrapNodes = dnsDiscoveryURL

newConfiguration = setWakuConfig(newConfiguration, wakuVersion)

Expand Down
2 changes: 0 additions & 2 deletions src/app_service/service/settings/dto/settings.nim
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ type PinnedMailserver* = object
goWakuTest*: string
statusTest*: string
statusProd*: string
shardsTest*: string

type CurrentUserStatus* = object
statusType*: StatusType
Expand Down Expand Up @@ -164,7 +163,6 @@ proc toPinnedMailserver*(jsonObj: JsonNode): PinnedMailserver =
discard jsonObj.getProp("go-waku.test", result.goWakuTest)
discard jsonObj.getProp("status.test", result.statusTest)
discard jsonObj.getProp("status.prod", result.statusProd)
discard jsonObj.getProp("shards.test", result.shardsTest)

proc toCurrentUserStatus*(jsonObj: JsonNode): CurrentUserStatus =
var statusTypeInt: int
Expand Down
4 changes: 0 additions & 4 deletions src/app_service/service/settings/service.nim
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@ QtObject:
return self.settings.pinnedMailserver.statusTest
elif (fleet == Fleet.StatusProd):
return self.settings.pinnedMailserver.statusProd
elif (fleet == Fleet.ShardsTest):
return self.settings.pinnedMailserver.shardsTest
return ""

proc pinMailserver*(self: Service, mailserverID: string, fleet: Fleet): bool =
Expand All @@ -440,8 +438,6 @@ QtObject:
self.settings.pinnedMailserver.statusTest = mailserverID
elif (fleet == Fleet.StatusProd):
self.settings.pinnedMailserver.statusProd = mailserverID
elif (fleet == Fleet.ShardsTest):
self.settings.pinnedMailserver.shardsTest = mailserverID
return true
return false

Expand Down
6 changes: 0 additions & 6 deletions ui/app/AppLayouts/Profile/popups/FleetsModal.qml
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,5 @@ ModalPopup {
fleetName: Constants.status_prod
buttonGroup: fleetSettings
}

FleetRadioSelector {
advancedStore: popup.advancedStore
fleetName: Constants.shards_test
buttonGroup: fleetSettings
}
}
}
3 changes: 1 addition & 2 deletions ui/app/AppLayouts/Profile/stores/AdvancedStore.qml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ QtObject {
property bool isWakuV2: root.fleet === Constants.waku_prod ||
root.fleet === Constants.waku_test ||
root.fleet === Constants.status_test ||
root.fleet === Constants.status_prod ||
root.fleet === Constants.shards_test
root.fleet === Constants.status_prod

readonly property bool isFakeLoadingScreenEnabled: localAppSettings.fakeLoadingScreenEnabled ?? false
property bool isManageCommunityOnTestModeEnabled: false
Expand Down
1 change: 0 additions & 1 deletion ui/imports/utils/Constants.qml
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,6 @@ QtObject {
readonly property string waku_test: "wakuv2.test"
readonly property string status_test: "status.test"
readonly property string status_prod: "status.prod"
readonly property string shards_test: "shards.test"

readonly property int browserSearchEngineNone: 0
readonly property int browserSearchEngineGoogle: 1
Expand Down
2 changes: 1 addition & 1 deletion vendor/status-go
Submodule status-go updated 84 files
+1 −1 VERSION
+0 −2 api/defaults.go
+96 −144 appdatabase/migrations/bindata.go
+0 −1 appdatabase/migrations/sql/1699577175_use_shards.up.sql
+3 −4 cmd/ping-community/main.go
+1 −1 go.mod
+2 −2 go.sum
+19 −22 node/status_node_services.go
+2 −14 nodecfg/node_config.go
+0 −3 params/config.go
+3 −1 protocol/common/message_sender.go
+19 −0 protocol/common/shard.go
+1 −1 protocol/communities/community.go
+3 −1 protocol/communities/manager.go
+1 −4 protocol/communities_messenger_helpers_test.go
+3 −1 protocol/messenger.go
+3 −3 protocol/messenger_communities.go
+3 −1 protocol/messenger_contacts.go
+3 −5 protocol/messenger_handler.go
+3 −1 protocol/messenger_mailserver.go
+1 −2 protocol/requests/set_community_shard.go
+9 −7 protocol/transport/filters_manager.go
+3 −22 protocol/transport/transport.go
+10 −8 services/mailservers/api_test.go
+1 −4 vendor/github.com/waku-org/go-waku/waku/persistence/db_key.go
+0 −22 vendor/github.com/waku-org/go-waku/waku/persistence/driver_type.go
+2 −1 vendor/github.com/waku-org/go-waku/waku/persistence/sql_queries.go
+4 −15 vendor/github.com/waku-org/go-waku/waku/persistence/store.go
+14 −43 vendor/github.com/waku-org/go-waku/waku/v2/discv5/discover.go
+22 −17 vendor/github.com/waku-org/go-waku/waku/v2/node/localnode.go
+1 −1 vendor/github.com/waku-org/go-waku/waku/v2/node/service.go
+18 −28 vendor/github.com/waku-org/go-waku/waku/v2/node/wakunode2.go
+2 −10 vendor/github.com/waku-org/go-waku/waku/v2/node/wakuoptions.go
+2 −1 vendor/github.com/waku-org/go-waku/waku/v2/payload/waku_payload.go
+13 −4 vendor/github.com/waku-org/go-waku/waku/v2/peermanager/connection_gater.go
+6 −15 vendor/github.com/waku-org/go-waku/waku/v2/peermanager/peer_connector.go
+26 −168 vendor/github.com/waku-org/go-waku/waku/v2/peermanager/peer_manager.go
+2 −1 vendor/github.com/waku-org/go-waku/waku/v2/peermanager/service_slot.go
+2 −42 vendor/github.com/waku-org/go-waku/waku/v2/protocol/content_filter.go
+4 −1 vendor/github.com/waku-org/go-waku/waku/v2/protocol/content_topic.go
+2 −0 vendor/github.com/waku-org/go-waku/waku/v2/protocol/enr/localnode.go
+14 −14 vendor/github.com/waku-org/go-waku/waku/v2/protocol/enr/shards.go
+65 −121 vendor/github.com/waku-org/go-waku/waku/v2/protocol/filter/client.go
+33 −46 vendor/github.com/waku-org/go-waku/waku/v2/protocol/filter/options.go
+0 −60 vendor/github.com/waku-org/go-waku/waku/v2/protocol/filter/pb/validation.go
+69 −55 vendor/github.com/waku-org/go-waku/waku/v2/protocol/filter/server.go
+4 −0 vendor/github.com/waku-org/go-waku/waku/v2/protocol/legacy_filter/filter_map.go
+24 −51 vendor/github.com/waku-org/go-waku/waku/v2/protocol/legacy_filter/waku_filter.go
+18 −17 vendor/github.com/waku-org/go-waku/waku/v2/protocol/legacy_filter/waku_filter_option.go
+8 −8 vendor/github.com/waku-org/go-waku/waku/v2/protocol/lightpush/metrics.go
+0 −48 vendor/github.com/waku-org/go-waku/waku/v2/protocol/lightpush/pb/validation.go
+75 −109 vendor/github.com/waku-org/go-waku/waku/v2/protocol/lightpush/waku_lightpush.go
+32 −25 vendor/github.com/waku-org/go-waku/waku/v2/protocol/lightpush/waku_lightpush_option.go
+0 −3 vendor/github.com/waku-org/go-waku/waku/v2/protocol/metadata/pb/generate.go
+0 −229 vendor/github.com/waku-org/go-waku/waku/v2/protocol/metadata/pb/waku_metadata.pb.go
+0 −13 vendor/github.com/waku-org/go-waku/waku/v2/protocol/metadata/pb/waku_metadata.proto
+0 −253 vendor/github.com/waku-org/go-waku/waku/v2/protocol/metadata/waku_metadata.go
+0 −47 vendor/github.com/waku-org/go-waku/waku/v2/protocol/pb/validation.go
+5 −25 vendor/github.com/waku-org/go-waku/waku/v2/protocol/peer_exchange/client.go
+1 −4 vendor/github.com/waku-org/go-waku/waku/v2/protocol/peer_exchange/enr_cache.go
+6 −13 vendor/github.com/waku-org/go-waku/waku/v2/protocol/peer_exchange/protocol.go
+27 −13 vendor/github.com/waku-org/go-waku/waku/v2/protocol/peer_exchange/waku_peer_exchange_option.go
+109 −42 vendor/github.com/waku-org/go-waku/waku/v2/protocol/pubsub_topic.go
+47 −103 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/broadcast.go
+0 −130 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/config.go
+0 −22 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/options.go
+19 −44 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/subscription.go
+0 −102 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/topic_events.go
+3 −1 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/validators.go
+265 −182 vendor/github.com/waku-org/go-waku/waku/v2/protocol/relay/waku_relay.go
+55 −60 vendor/github.com/waku-org/go-waku/waku/v2/protocol/shard.go
+0 −68 vendor/github.com/waku-org/go-waku/waku/v2/protocol/store/pb/validation.go
+82 −96 vendor/github.com/waku-org/go-waku/waku/v2/protocol/store/waku_store_client.go
+14 −2 vendor/github.com/waku-org/go-waku/waku/v2/protocol/store/waku_store_common.go
+39 −83 vendor/github.com/waku-org/go-waku/waku/v2/protocol/store/waku_store_protocol.go
+5 −5 vendor/github.com/waku-org/go-waku/waku/v2/protocol/subscription/subscriptions_map.go
+4 −4 vendor/github.com/waku-org/go-waku/waku/v2/rendezvous/rendezvous.go
+0 −31 vendor/github.com/waku-org/go-waku/waku/v2/utils/multiaddr.go
+142 −0 vendor/github.com/waku-org/go-waku/waku/v2/utils/peer.go
+1 −3 vendor/modules.txt
+8 −10 wakuv2/common/filter.go
+29 −37 wakuv2/config.go
+4 −1 wakuv2/filter_manager.go
+57 −75 wakuv2/waku.go

0 comments on commit a33ff4d

Please sign in to comment.