Skip to content

Commit

Permalink
fix(@desktop/wallet): Send Modal doesn't fill available height and Dr…
Browse files Browse the repository at this point in the history
…op Shadow missing in Send Modal Footer

Also fixed a crash found while fixing the above bugs

fixed #7133, #7134
  • Loading branch information
Khushboo-dev-cpp committed Sep 19, 2022
1 parent 8b02d8d commit 8c4ce7b
Show file tree
Hide file tree
Showing 6 changed files with 233 additions and 233 deletions.
2 changes: 1 addition & 1 deletion src/app_service/service/transaction/service.nim
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ QtObject:
proc confirmTransactionStatus(self: Service, pendingTransactions: JsonNode) =
for trx in pendingTransactions.getElems():
let transactionReceipt = self.getTransactionReceipt(trx["network_id"].getInt, trx["hash"].getStr)
if transactionReceipt.kind != JNull:
if transactionReceipt != nil and transactionReceipt.kind != JNull:
self.deletePendingTransaction(trx["network_id"].getInt, trx["hash"].getStr)
let ev = TransactionMinedArgs(
data: trx["additionalData"].getStr,
Expand Down
2 changes: 1 addition & 1 deletion ui/imports/shared/controls/AssetAndAmountInput.qml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ Item {
tokenAssetSourceFn: function (symbol) {
return symbol ? Style.png("tokens/" + symbol) : defaultToken
}
searchTokenSymbolByAddress: function (address) {
searchTokenSymbolByAddressFn: function (address) {
if(popup.selectedAccount) {
return popup.selectedAccount.findTokenSymbolByAddress(address)
}
Expand Down
4 changes: 2 additions & 2 deletions ui/imports/shared/panels/StatusAssetSelector.qml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Item {
property var tokenAssetSourceFn: function (symbol) {
return ""
}
property var searchTokenSymbolByAddress: function (address) {
property var searchTokenSymbolByAddressFn: function (address) {
return ""
}

Expand Down Expand Up @@ -74,7 +74,7 @@ Item {
filters: [
ExpressionFilter {
expression: {
var tokenSymbolByAddress = searchTokenSymbolByAddress(d.searchString)
var tokenSymbolByAddress = searchTokenSymbolByAddressFn(d.searchString)
return symbol.startsWith(d.searchString.toUpperCase()) || name.toUpperCase().startsWith(d.searchString.toUpperCase()) || (tokenSymbolByAddress!=="" && symbol.startsWith(tokenSymbolByAddress))
}
}
Expand Down
Loading

0 comments on commit 8c4ce7b

Please sign in to comment.