Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow digit in uniform_name #22

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Allow digit in uniform_name #22

merged 4 commits into from
Aug 26, 2024

Conversation

johnksv
Copy link
Member

@johnksv johnksv commented Aug 26, 2024

Some teams have this preference

@johnksv
Allow digit in uniform_name
f6ece98 
Some teams have this preference
@johnksv johnksv requested a review from a team as a code owner August 26, 2024 08:45
@github-actions github-actions bot added the json-schema Updates to the source models label Aug 26, 2024
@github-actions github-actions bot added the java Updates to the generated Java project label Aug 26, 2024
ArielKarlsen
ArielKarlsen approved these changes Aug 26, 2024
View reviewed changes
Copy link

@ArielKarlsen ArielKarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Most of our teams only use letters, however, we have noticed some newer teams using numbers. I do not see a reason this shouldn´t be allowed ✨

kschulst
kschulst reviewed Aug 26, 2024
View reviewed changes
Copy link

@kschulst kschulst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively:

^[a-z][a-z0-9-]*$

if we want to make sure that team names cannot start with a digit

johnksv and others added 2 commits August 26, 2024 11:05
@johnksv
Allow digit in uniform_name
6ae8b9d 
Some teams have this preference. First char should be a letter
@dapla-bot
[GENERATE] Java classes from JSON Schema
9d081b8
@johnksv johnksv merged commit a3d17fc into main Aug 26, 2024
3 checks passed
@johnksv johnksv deleted the allow-digit-in-uniform-name branch August 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschulst kschulst kschulst approved these changes

@ArielKarlsen ArielKarlsen ArielKarlsen approved these changes

Assignees
No one assigned
Labels
java Updates to the generated Java project json-schema Updates to the source models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnksv @kschulst @ArielKarlsen