Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add GithubIcon 'w' and 'h' props #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jt-ziolo
Copy link

On line 68 of [path].js:

<GithubIcon w={24} h={24} />

the props w and h are excluded from the definition of GithubIcon (lines 229 - 244 of Icons.js):

export function GithubIcon() { // should be GithubIcon({ w, h })
  return (
    <svg
      xmlns="http://www.w3.org/2000/svg"
      width="24" // should be {w}
      height="24" // should be {h}
      fill="none"
      viewBox="0 0 24 24"
    >
      <path
	// ...
	></path>
    </svg>
  );
}

Fixed the following issue:
On line 68 of [path].js, the props ``w`` and ``h`` are passed into GithubIcon, but these props are excluded from the definition of GithubIcon (lines 229 - 244 of Icons.js).
@jt-ziolo jt-ziolo marked this pull request as ready for review June 29, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant