Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sysfs mount. #99

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Aug 1, 2022

Fixes #98, supersedes #97.

@maleadt

This comment was marked as outdated.

@maleadt

This comment was marked as outdated.

@maleadt maleadt force-pushed the fixup_sysfs_mount branch 2 times, most recently from 3b0938f to 45760d7 Compare August 1, 2022 14:04
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #99 (165e5cc) into main (00b3386) will decrease coverage by 0.52%.
The diff coverage is n/a.

❗ Current head 165e5cc differs from pull request most recent head 609658b. Consider uploading reports for the commit 609658b to get more accurate results

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   80.14%   79.61%   -0.53%     
==========================================
  Files           6        6              
  Lines         569      569              
==========================================
- Hits          456      453       -3     
- Misses        113      116       +3     
Impacted Files Coverage Δ
src/Sandbox.jl 73.04% <0.00%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b3386...609658b. Read the comment docs.

@maleadt
Copy link
Contributor Author

maleadt commented Aug 1, 2022

DockerExecutor failures with the nested test unrelated, and also happen on v1.3.0: #100. So this should be good to go, I think.

EDIT: the failure is due to docker not being available in the nested environment. That seems obvious; how did this ever work? @staticfloat

When scanning all current mount points, we must be able to skip
mountpoints that we cannot access, such as if `docker` is running and
has internal mounts that are not visible to our current user.
@staticfloat
Copy link
Owner

The inner child of nesting can only really ever work with an unprivileged user namespace executor. Previously, the nesting test that uses docker would use the DockerExecutor on the outside, but the unprivileged usernamespace executor on the inside. Looking at the build logs, it seems that the UnprivilegedUserNamespaceExecutor was completely broken on the CI machine, so those tests were all getting skipped. I've since taken a look, and it appears this is because there are some inaccessible mount points listed in the kernel's list of mounts. I've pushed a commit that works locally, let's see if it works on CI.

@staticfloat
Copy link
Owner

Looks good!

@staticfloat staticfloat merged commit 14dde40 into staticfloat:main Aug 1, 2022
@maleadt maleadt deleted the fixup_sysfs_mount branch August 1, 2022 19:00
@maleadt
Copy link
Contributor Author

maleadt commented Aug 1, 2022

Great! Care to tag a new version, or do you want to have this on master for a while?

@staticfloat
Copy link
Owner

staticfloat commented Aug 1, 2022

I'm going to tag a new version once I can successfully deploy the new JLL to some of our buildbots. I've run into a few issues (such as not having a valid /etc/mtab) that I'm ironing out. :)

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sysfs bindmound broke unpriviliged runner on Arch Linux
2 participants