-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sysfs mount. #99
Fix sysfs mount. #99
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3b0938f
to
45760d7
Compare
45760d7
to
165e5cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 80.14% 79.61% -0.53%
==========================================
Files 6 6
Lines 569 569
==========================================
- Hits 456 453 -3
- Misses 113 116 +3
Continue to review full report at Codecov.
|
DockerExecutor failures with the nested test unrelated, and also happen on v1.3.0: #100. So this should be good to go, I think. EDIT: the failure is due to |
When scanning all current mount points, we must be able to skip mountpoints that we cannot access, such as if `docker` is running and has internal mounts that are not visible to our current user.
The inner child of nesting can only really ever work with an unprivileged user namespace executor. Previously, the nesting test that uses docker would use the DockerExecutor on the outside, but the unprivileged usernamespace executor on the inside. Looking at the build logs, it seems that the UnprivilegedUserNamespaceExecutor was completely broken on the CI machine, so those tests were all getting skipped. I've since taken a look, and it appears this is because there are some inaccessible mount points listed in the kernel's list of mounts. I've pushed a commit that works locally, let's see if it works on CI. |
Looks good! |
Great! Care to tag a new version, or do you want to have this on master for a while? |
I'm going to tag a new version once I can successfully deploy the new JLL to some of our buildbots. I've run into a few issues (such as not having a valid Thanks for fixing this! |
Fixes #98, supersedes #97.