chore: lightgbm description fix

see #31
statgarten · Dec 13, 2023 · 396f7a4 · 396f7a4
1 parent 76335ff
commit 396f7a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: stove
 Title: Stove
-Version: 1.1.1
+Version: 1.2.0
 Authors@R: c(
   person("Yeonchan", "Seong", , "ycseong07@gmail.com", role = c("aut", "cre")),
   person("Jinhwan", "Kim", , email = "hwanistic@gmail.com", role = "ctb"))
@@ -16,6 +16,7 @@ Suggests:
     testthat (>= 3.0.0)
 VignetteBuilder: knitr
 Config/testthat/edition: 3
+Depends: lightgbm (== 3.3.5)
 Imports: 
     brulee (>= 0.1.0),
     C50 (>= 0.1.6),
@@ -33,7 +34,6 @@ Imports:
     kknn (>= 1.3.1),
     klaR (>= 1.7-1),
     LiblineaR (>= 2.10-12),
-    lightgbm (>= 3.3.2),
     magrittr (>= 2.0.3),
     naivebayes (>= 0.9.7),
     nnet (>= 7.3-17),

diff --git a/R/fitting.R b/R/fitting.R
@@ -35,6 +35,8 @@ bayesOptCV <- function(rec = NULL,
       hardhat::extract_parameter_set_dials() %>%
       recipes::update(mtry = dials::finalize(mtry(), trainingData))
 
+    print("ERROR with lightgbm pacakge: use 3.3.5 version not 4.2.0 version")
+    print('devtools::install_version("lightgbm", version = "3.3.5", repos = "http://cran.us.r-project.org")')
     set.seed(seed = as.numeric(seed))
     result <-
       tunedWorkflow %>%